PR to run tests for 427_confiuration_import_message_broker

[mslabko]

Description (*)

Related Pull Requests

magento/commerce-data-export#15
magento/storefront-message-broker#4

Fixed Issues (if relevant)

1. Fixes magento/catalog-storefront#<issue_number>

Questions or comments

Code Review Checklist (*)

See detailed checklist

• Story AC is completed
• proposed changes correspond to Magento Technical Vision
• new or changed code is covered with web-api/integration tests (if applicable)
  • expected results in test verified with data from fixture
• no backward incompatible changes
• Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
  • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
  • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
• Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
  • Check composer.json dependencies
• Legacy code is deleted
  • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
  • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
  • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
  • Any “mapper” on Message Broker (between Export API and SF API)
    • if mapper still needed, verify fields used in mapping, remove not relevant fields

[mslabko]

@magento run all tests

[mslabko]

QA:
testing with path "analytics/subscription/enabled:" on "Monolith installation (all modules together)"

• not working with change value from "Disabled -> Enabled" - look like issue with "isValueChanged"
• not push changes to queue: \Magento\ConfigurationDataExporter\Model\ConfigExportCallback::publishMessage

[2020-12-02 22:30:49] main.ERROR: topic "system.configuration.export": error on publish message "{"event_type":"config_export_update"}" {"exception":"[object] (InvalidArgumentException(code: 0): Data in topic \"system.configuration.export\" must be of type \"Magento\\ConfigurationImportMessageBroker\\Event\\Data\\ChangedConfig\". \"Magento\\ConfigurationDataExporter\\Event\\Data\\ChangedConfig\" given. at /var/www/magento2ce/lib/internal/Magento/Framework/MessageQueue/MessageValidator.php:161)"} []

• full sync not working as well

reason: app/code/Magento/CatalogExport/README.md

Right now we can use the same approach: Lets' create for Message Broker new module ConfigurationDataExporter which will contain "app/code/Magento/ConfigurationDataExporter/Event/Data" files. + add README to this module similar to CatalogExport/README.md

[lykhachov]

@magento run all tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Integration Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run all tests

[lykhachov]

@magento run all tests

[lykhachov]

@magento run all tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run Static Tests

[lykhachov]

@magento run all tests