Price change notification #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Price change events
- Price change events
- Base price / special price batch processing
- Events batch processing
- Events batch processing
- Events batch processing
…port into story-443-price-notifications
- Events batch processing
- Improved custom option price notifications - Added/Improved custom option type price notifications
- Events batch processing
- Events batch processing
-Added amqp
- Events batch processing
…port into story-443-price-notifications
-Reworked message formatting for tier prices, customizable prices and normal prices
- Events batch processing
- Price events
- Price events
- Price events
|
@magento run all tests |
- Static tests fix
|
@magento run Static Tests |
- Price events
|
@magento run all tests |
This was referenced Dec 15, 2020
This was referenced Dec 15, 2020
Merged
mslabko
reviewed
Dec 15, 2020
| @@ -1,38 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
app/code/Magento/ProductVariantDataExporter/Test/Integration/AbstractProductVariantsTest.php
Please, delete usage of this class
mmansoor-magento
pushed a commit
that referenced
this pull request
Dec 16, 2020
…e-data-export-15 [Imported] 427: System configuration full and updates export.
- Integration test fix
…port into story-443-price-notifications
|
@magento run all tests |
1 similar comment
|
@magento run all tests |
|
| $actualVariations = $actualData[$data['parent_id']] ?? []; | ||
| $eventType = \in_array($data['entity_id'], $actualVariations) ? self::EVENT_VARIATION_CHANGED | ||
| : self::EVENT_VARIATION_DELETED; | ||
| $websiteId = (string)$this->storeManager->getWebsite(WebsiteInterface::ADMIN_CODE)->getWebsiteId(); |
There was a problem hiding this comment.
will website id be always equal to admin website id?
There was a problem hiding this comment.
yes, AFAIK not possible to change variation on website / store scope
| use Magento\Framework\Exception\NoSuchEntityException; | ||
| use Magento\Store\Model\StoreManagerInterface; | ||
| use Psr\Log\LoggerInterface; | ||
| use Magento\Store\Api\Data\WebsiteInterface; |
There was a problem hiding this comment.
is not used, please remove
| use Magento\DataExporter\Exception\UnableRetrieveData; | ||
| use Magento\Framework\App\ResourceConnection; | ||
| use Magento\Framework\Exception\NoSuchEntityException; | ||
| use Magento\Store\Api\Data\WebsiteInterface; |
There was a problem hiding this comment.
is not used, please remove
…ranovs10/commerce-data-export into story-469-gift-cards
Gift cards price notification events
|
@magento run all tests |
|
@magento import pr to magento-commerce/commerce-data-export |
|
@mslabko the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Related Pull Requests
magento/magento2#30790
https://github.com/magento/partners-magento2ee/pull/404
skovalenk/magento2#1
https://github.com/skovalenk/partners-magento2ee/pull/1
Fixed Issues (if relevant)
Questions or comments
Code Review Checklist (*)