Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Incorrect link to JSCS site. #5632

Closed
p-bystritsky opened this issue Oct 9, 2019 · 3 comments
Closed

Incorrect link to JSCS site. #5632

p-bystritsky opened this issue Oct 9, 2019 · 3 comments

Comments

@p-bystritsky
Copy link

Topic clarification/correction request

Topic Link

https://devdocs.magento.com/guides/v2.3/coding-standards/code-standard-javascript.html#eslint-and-jscs-tools

Description

Link to JSCS site is incorrect. Looks like this project no longer has a separate site.
https://github.com/jscs-dev/node-jscs/blob/master/README.md

Possible solutions

Additional information

@brunoroeder
Copy link
Contributor

I'm working on it.

@shrielenee
Copy link
Contributor

Yo @brunoroeder --- We closed the applicable PR for this because it exceeded our two week timeframe for response.

If you, or someone else, wants to work this feel free to open a new PR or reopen the closed one.

🙅

@atwixfirster
Copy link
Contributor

Let's try with this one - #6040

Thank you!

dobooth added a commit that referenced this issue Nov 20, 2019
keharper added a commit that referenced this issue Nov 27, 2019
* Update first-time-setup-import-import.md

* adding new information from stopwords elasticsearch

* settings

* settings

* settings spaces

* settings by MD029

* settings by MD029

* adding variable from github url tree

* adding url variable

* adding fix MD009

* Using the /search endpoint

* Update rest-api.yml

* Update search-endpoint.md

* Update search-endpoint.md

* Updates as per request points

* Symlink for v2.3

* Symlink modification

* Updated repo path

* Update search-endpoint.md

* Fixed double quotes.

* Google 3.0.2 - RN

Initial Draft

* Outline differences between search types and v1/search and v1/products

* Update search-endpoint.md

* Added PHP note

added a note regarding required PHP setting for Google reCAPTCHA. This update was vetted and approved by Rick Tempesta.

* Update guides/v2.3/security/google-recaptcha.md

Accepted approver's suggestion

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* fixed broken link

* removing variable and remove link for example

* Added JS script name resolution examples

* Fixed incorrect syntax for custom KO checked binding

* Added missing example for i18n Magento binding syntax

* Incorrect reference url fixed

The reference url was pointing to Customer/Api instead of Catalog/Api

* Fixing the LESS snippet syntax

* Added note for ece-tools patch process fix (#6004)

* Added fix for patch process issue introduced
  by version scheme change for 
  security only patches in Magento 2.3.2-p2.

* Updates yml. Delete unused file.

* Fixed typo.

* Linting

* Grammar and formatting

* Trailing space

* Trailing spaces

* Google 3.0.2 updates

release notes, release, compatibility.

* Markdown linting: Enable rule MD036 (emphasis used instead of a header) (#6023)

* Added colons to common psuedo-headers

* Added colons to less common psuedo headers

* Added colons to more less common psuedo headers

* Removed emphasis from captions

* Fixed up links.

* Added note for ece-tools patch process fix (#6004) (#6020)

* Added fix for patch process issue introduced
  by version scheme change for
  security only patches in Magento 2.3.2-p2.

* Corrected RESOURCE_CONFIGURATION merge example (#6005)

* Fixes #6025

* updated compatible versions

added 2.3.3

* Update extensions/google-shopping-ads/release-notes/index.md

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* Update extensions/google-shopping-ads/release-notes/index.md

Co-Authored-By: Shrie Spangler <spangler@adobe.com>

* Grammar and formatting

* magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command-line tool (#5971)

* magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command line tool

- https://devdocs.magento.com/guides/v2.2/cloud/env/environment-vars_magento.html
- https://devdocs.magento.com/guides/v2.3/cloud/env/environment-vars_magento.html

* magento/devdocs#: Cloud. Set ADMIN_URL via magneto-cloud command line tool

* Update rake build:prod

Add init task to prerequisites.

* Adding question mark when nullable value is declared

* Adding nullable param question mark in v2.2

* #5632: Incorrect link to JSCS site.

https://devdocs.magento.com/guides/v2.2/coding-standards/code-standard-javascript.html
https://devdocs.magento.com/guides/v2.3/coding-standards/code-standard-javascript.html

* Updated What's New with changes since November 4 (#6030)

* Updated What's New with changes since November 4

* Merge UI component PRs (#6041)

* Update Paging UI component documentation (#6039)

* Update Paging UI component documentation

* Grammar updates

* Update DragAndDrop UI component documentation (#6038)

* Update DragAndDrop UI component documentation

* Grammar updates

* Update date column UI component documentation (#6037)

* Update date column UI component documentation

* Grammar update

* Update ui columns documentation (#6036)

* Update ui columns documentation

* Adjust the example title

* Grammar updates

* Update UI column component documentation (#6034)

* Update UI column component documentation

* Update ui-column.md

* fixed linting error

* removing Google 3.0.2 info

will republish when 3.0.2 is released.

* update whatsnew

remove google 3.0.2 release notes from whatsnew

* magento/devdocs#: Add customerOrders query API errors

- https://devdocs.magento.com/guides/v2.3/graphql/queries/customer-orders.html

* magento/devdocs#: Add customerDownloadableProducts query API errors

- https://devdocs.magento.com/guides/v2.3/graphql/queries/customer-downloadable-products.html

* Optimized Index Management screen capture (#6050)

* Updated Architecture topic for Starter plan (#6043)

Per @jefflathan1:  Starter stores are not entitled to TAms in the same way that Pro stores are. We need to remove the Technical Account Manager entry for Starter, leaving it blank.

* #5218: Need info about structures in Adding a custom indexer (#6042)

* #5218:  Need info about structures in Adding a custom indexer

https://devdocs.magento.com/guides/v2.2/extension-dev-guide/indexing-custom.html
https://devdocs.magento.com/guides/v2.3/extension-dev-guide/indexing-custom.html

* Grammar updates

@atwixfirster I made many grammatical changes. Please review my changes, especially the `shared_index`  description,

* Updating Fieldset UiComponent documentation (#6045)

* Adding the Fieldset UiComponent additional information

* Updating the example

* Minor adjustments

* Update ui-fieldset.md

* Update view-models.md

I wasn't closing a tag page

* GraphQL caching with Fastly (#6031)

* GraphQL caching with Fastly

* Update guides/v2.3/graphql/caching.md

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Added steps to check Fastly version on Cloud

* Fixed syntax

* Apply suggestions from code review

* Editorial fixes

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Delete space at end of sentence

* Update caching.md

* GraphQL: small changes (#6052)

* removing cloud bi from toc

* Editorial fix (#6054)

* GraphQL caching with Fastly

* Update guides/v2.3/graphql/caching.md

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Added steps to check Fastly version on Cloud

* Fixed syntax

* Apply suggestions from code review

* Editorial fixes

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Delete space at end of sentence

* Update caching.md

* Editorial fix

* Add MBI to search and update site switcher (#6062)

* KB migration: Restore an environment (#6063)

* Added new topic and TOC entry

* Added files

* Added optimized images

* Fixed markdown

* Rewrote content

* Fixed links

* Fixed MD errors

* Added xref to new topic

* Fixed xref

* Apply suggestions from code review

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

* Revised per peer review

* Missed a var

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <meker@adobe.com>

* Fixed incorrect terminology and added references

* Converting the Display Magento error report number KB to devdocs (#6061)

* Converting the Display Magento error report number KB to devdocs

* ElasticSearch: Nigix proxy config correction

* Set warning for STATIC_CONTENT_SYMLINK variable (#6065)

* Add STATIC_CONTENT_SYMLINK removal note

* Remove ece-version tool

* Add additional note

* Add supported service versions of RabbitMQ

From the platform.sh docs https://docs.platform.sh/configuration/services/rabbitmq.html

* Updating cli documentation

* Add link to supported version list

* Remove remote_markdown completely

* Fix site variable

* Add example for local RabbitMQ Management UI

* Little changes

* Update guides/v2.2/mtf/configuration.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Update guides/v2.2/mtf/configuration.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Update guides/v2.2/mtf/configuration.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Update guides/v2.2/mtf/mtf_entities/mtf_handler.md

Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>

* Fix style

* Small formatting change.

* Resolve code quotation error. (#6072)

* Add docs for new Adobe-generated alert policies for New Relic (#6075)

- Updated New Relic topic to add Adobe-generated alert policies
- Added information about New Relic monitoring to the
following topics: Architecture, and Go Live checklist
- Added new Monitor Performance topic to Manage Project section
- Added images for New Relic alert policies and project credentials

* fix linting error
@hguthrie hguthrie removed the Help Wanted Help wanted for issue/PR label Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants