This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
DO NOT MERGE UNTIL 2.3.1. GraphQL: add the option_id parameter for customizable options #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keharper
added
Internal Dev
jeff-matthews
approved these changes
Nov 15, 2018
|
I just realized that the code checked in for magento/graphql-ce#247 will be merged in the 2.3.1 branch. |
keharper
changed the title
|
Closing this PR because dealing with the merge conflicts will take longer than creating a new PR in the 2.3.1-integration branch (which didn't exist when this PR was created). |
|
Hi @keharper, thank you for your contribution! |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will add the
option_idparameter to the CustomizableOptionInterface topic.I also added an example, which was previously missing.
Source: magento/graphql-ce#247
Additional information
List all affected URLs
https://devdocs.magento.com/guides/v2.3/graphql/reference/customizable-option-interface.html