Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Graphql checkout tutorial #4271

Merged
merged 44 commits into from
Jun 25, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Apr 17, 2019

Purpose of this PR

This PR adds a tutorial for the checkout workflow regarding issue #589.

PR contains a pack of GraphQl API functions which is currently under develop:

  • setShippingAddressesOnCart
  • setBillingAddressOnCart
  • setShippingMethodsOnCart
  • setPaymentMethodOnCart
  • applyCouponToCart
  • removeCouponFromCart
  • setGuestEmailOnCart
  • placeOrder

Affected URLs

New URLs:

Links to source code

Thank you!

whatsnew
Added the GraphQL checkout tutorial, which provides an overview of the steps you need place an order on behalf of a guest or logged-in user.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar
Copy link
Contributor

rogyar commented Apr 18, 2019

Hi @keharper. Could you check please if you already have this information prepared?
If not, I would suggest splitting this PR into smaller chunks.

Thank you

@rogyar rogyar added the Waiting for Response Waiting for response from internal/external parties label Apr 18, 2019
@keharper
Copy link
Contributor

Wow. Just wow.

This is massive, and I'm absolutely stunned. It'll take a while to fully process this and figure out everything. Give me a week to figure this out.

@keharper keharper self-assigned this Apr 18, 2019
@rogyar rogyar added the New Topic A major update published as an entirely new document label Apr 23, 2019
@keharper keharper added xx2.3.2 Magento 2.3.2 changes Community Docs impacted by community code contribution labels Apr 23, 2019
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fantastic tutorial. I've added a lot of quote reference material in the develop branch since you submitted the tutorial. You might want to add more links to those topics.

@keharper keharper removed the Waiting for Response Waiting for response from internal/external parties label Jun 1, 2019
@atwixfirster
Copy link
Contributor Author

@keharper , moving PR to your plate again :)

All suggestions have been implemented.

Please verify. Thank you!

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global: Change all instances of {{ SOMETHING }} to { SOMETHING } or create a different way to represent tutorial variables. Don't change our system variables like {{ page.baseurl }}

The system attempts to process strings like {{ CART_ID }} in the same way as {{ page.baseurl }}, and so they display as null.

@atwixfirster
Copy link
Contributor Author

Global: Change all instances of {{ SOMETHING }} to { SOMETHING } or create a different way to represent tutorial variables. Don't change our system variables like {{ page.baseurl }}

The system attempts to process strings like {{ CART_ID }} in the same way as {{ page.baseurl }}, and so they display as null.

done

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round, I think. Don't forget to update the samples for adding products to the cart.

Merge remote-tracking branch 'upstream/master' into graphql-checkout-tutorial
@atwixfirster
Copy link
Contributor Author

@keharper

Don't forget to update the samples for adding products to the cart.

This point already done in the guides/v2.3/graphql/tutorials/checkout/checkout-add-product-to-cart.md

@keharper keharper changed the base branch from develop to master June 25, 2019 15:29
@keharper
Copy link
Contributor

running tests

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 704db1a into magento:master Jun 25, 2019
@ghost
Copy link

ghost commented Jun 25, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Yippee-ki-yay. Thank you @atwixfirster for this massive contribution. You're a star.

@atwixfirster
Copy link
Contributor Author

Yippee-ki-yay. Thank you @atwixfirster for this massive contribution. You're a star.

Thank you, @keharper 😊

Thank you for all your hard work on this one 👍

@keharper keharper added the Special achievement High-value contributions that earn higher rewards and special attention label Jun 25, 2019
@magento-engcom-team magento-engcom-team added Major Update Significant original updates to existing content Technical Updates to the code or processes that alter the technical content of the doc labels Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Docs impacted by community code contribution Major Update Significant original updates to existing content New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner Special achievement High-value contributions that earn higher rewards and special attention Technical Updates to the code or processes that alter the technical content of the doc xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants