Feature/elasticsearch stopwords #5917
Conversation
magento-engcom-team
added
Partner: Webjump
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
| </arguments> | ||
| </type> | ||
| ``` | ||
| 3. In your module, create the directory `etc/stopwords`, inside add files .csv |
There was a problem hiding this comment.
Please, change the order of the words in the following explanation.
| 3. In your module, create the directory `etc/stopwords`, inside add files .csv | |
| 3. In your module, create the directory `etc/stopwords`, with the corresponding `.csv` files inside. |
Also, it would be really nice to have a reference (link) to the existing stopwords implementation in the Magento_Elasticsearch module.
rogyar
added
2.3.x
|
@luanalves I would also kindly ask you to take a look at the failing tests. Thank you! |
| ``` | ||
|
|
||
| 1. In your module, create the directory `etc/stopwords`, with the corresponding `.csv`. | ||
| [files inside.](https://github.com/magento/magento2/tree/2.3-develop/app/code/Magento/Elasticsearch/etc/stopwords){:target="_blank"} |
There was a problem hiding this comment.
Please, use the relative blob links instead of the direct absolute links. You can find an example at the very bottom of the following file.
I.e.
[lib/web/mage/accordion.js]: {{ site.mage2bloburl }}/{{ page.guide_version }}/lib/web/mage/accordion.jsThere was a problem hiding this comment.
Hi @rogyar the changes were taken care of but i had to add new variable
There was a problem hiding this comment.
Hi @luanalves Thanks for the contribution. We are not sure why you are creating a new variable. Files like _config.yml are important and they support the system in many ways. We would rather you not edit it. If you can back out that change, that would be great. Please use the existing vars if you can, or a direct link if you need a specific path.
|
@dobooth unffortunally, in the file _config.yml doesn't exists the variable or value reference a information "https://github.com/magento/magento2/tree", it is necessary . |
|
Hi @luanalves Please remove the new variable and use the blob path or a direct link to the tree if the distinction is critical. |
dobooth
added
Major Update
|
running tests |
|
running tests |
|
Hi @luanalves, thank you for your contribution! |
Purpose of this pull request
Change elasticsearch stopwords directory to custom module
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/config-guide/elasticsearch/es-config-stopwords.html
whatsnew
Added the "To change the directory from your module" section to the Configure Elasticsearch Stopwords in the Configuration Guide.