This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Updated repo path Actiongroups data file #5965
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshevtsov
suggested changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run rake
, the generation fails because of bad YAML syntax.
_data/actiongroups.yml): did not find expected key while parsing a block mapping at line 3218 column 8
Please resolve the issue, and test the branch:
- Generate a working preview with
rake
- Test external links with
rake test:external_links
dshevtsov
suggested changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changed file is a data file generated from a codebase. It cannot be edited. It has to be regenerated from the 2.3 branch to be valid.
Right. They used a double quote in the annotations. |
dshevtsov
approved these changes
Nov 18, 2019
running tests |
Hi @dobooth, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Site Improvements
Updates to tools, processes, and site architecture that improve reader and contributor experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) updates the links to the magento2 repo for data files.
It also deletes an extraneous data file.
Affected DevDocs pages