Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Updated repo path Actiongroups data file #5965

Merged
merged 9 commits into from
Nov 18, 2019
Merged

Updated repo path Actiongroups data file #5965

merged 9 commits into from
Nov 18, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Nov 11, 2019

Purpose of this pull request

This pull request (PR) updates the links to the magento2 repo for data files.
It also deletes an extraneous data file.

Affected DevDocs pages

@dobooth dobooth self-assigned this Nov 11, 2019
@dobooth dobooth added the Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience label Nov 11, 2019
@dobooth dobooth requested a review from dshevtsov November 11, 2019 15:36
Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run rake, the generation fails because of bad YAML syntax.

_data/actiongroups.yml): did not find expected key while parsing a block mapping at line 3218 column 8

Please resolve the issue, and test the branch:

  1. Generate a working preview with rake
  2. Test external links with rake test:external_links

Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed file is a data file generated from a codebase. It cannot be edited. It has to be regenerated from the 2.3 branch to be valid.

@dobooth
Copy link
Contributor Author

dobooth commented Nov 11, 2019

Right. They used a double quote in the annotations.

@dobooth dobooth requested a review from dshevtsov November 18, 2019 17:43
@dobooth
Copy link
Contributor Author

dobooth commented Nov 18, 2019

running tests

@dobooth dobooth merged commit 99227ee into master Nov 18, 2019
@ghost
Copy link

ghost commented Nov 18, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants