Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Fixed incorrect module dependency examples #5976

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Fixed incorrect module dependency examples #5976

merged 2 commits into from
Nov 12, 2019

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 12, 2019 •
edited
Loading

Purpose of this pull request

This pull request (PR) fixes the incorrect module dependency examples.

  • A module's require section in composer.json contains the hard dependencies, whereas
  • A module's suggest section in composer.json and <sequence/> node in module.xml contain the soft dependencies

Affected DevDocs pages

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@dobooth dobooth added 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc and removed Progress: approved labels Nov 12, 2019
@dobooth
Copy link
Contributor

dobooth commented Nov 12, 2019

running tests

@dobooth dobooth merged commit c5ffa72 into magento:master Nov 12, 2019
@ghost
Copy link

ghost commented Nov 12, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dobooth dobooth dobooth approved these changes

Assignees

@dobooth dobooth

Labels
2.2.x 2.3.x Magento 2.3 related changes Partner: Zilker Technology partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drpayyne @devops-devdocs @dobooth @magento-engcom-team