This repository was archived by the owner on Nov 19, 2024. It is now read-only.
magento/devdocs#: Extends information about creating a dynamic row system config. #5992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
atwixfirster
force-pushed
the
update-dynamic-rows-content
branch
from
a699e5c to
f2a57dd
Compare
rogyar
added
Technical
rogyar
suggested changes
Nov 13, 2019
| * | ||
| * @return string | ||
| */ | ||
| public function _toHtml(): string |
There was a problem hiding this comment.
It's not a big deal, but should we override the parent method scope of _toHtml()? It's protected in the parent class.
There was a problem hiding this comment.
@rogyar , I see such this approach in the existing Magento classes:
- Magento\CatalogInventory\Block\Adminhtml\Form\Field\Customergroup::_toHtml()
- Magento\Braintree\Block\Adminhtml\Form\Field\Countries::_toHtml()
- Magento\Braintree\Block\Adminhtml\Form\Field\CcTypes::_toHtml()
So, in my PR I've followed the same logic.
Thanks.
There was a problem hiding this comment.
I believe it's a sort of mechanical mistake. But, not a big deal, as I said.
rogyar
approved these changes
Nov 14, 2019
dobooth
removed
the
Technical
dobooth
approved these changes
Nov 14, 2019
|
running tests |
|
Hi @atwixfirster, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) extends current Creating a dynamic row system config topic and adds information how to add a custom drop-down option.
Affected DevDocs pages
whatsnew
Added additional steps and code to the Creating a dynamic row system config section in the Extensions Best Practices Guide.