Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Fixes magento/devdocs#6025 #6026

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Conversation

k4emic
Copy link

@k4emic k4emic commented Nov 19, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

"bundles/default": ["mage/template", "mage/apply/scripts", "mage/apply/main", "mage/mage", "mage/translate", "mage/loader"],
"bundles/cart": ["Magento_Ui/js/lib/validation/utils", "Magento_Ui/js/lib/validation/rules", "Magento_Ui/js/lib/validation/validation"]
}
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundles are now written in a single require.config instruction. This output might contain more spacing (one module per line) depending on whether you're using node.js, rhino or something else.

@k4emic k4emic closed this Nov 19, 2019
@ghost
Copy link

ghost commented Nov 19, 2019

Hi @k4emic, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@k4emic
Copy link
Author

k4emic commented Nov 19, 2019

Signed CLA

@k4emic k4emic reopened this Nov 19, 2019
@dobooth dobooth added 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Nov 19, 2019
@dobooth
Copy link
Contributor

dobooth commented Nov 19, 2019

running tests

@dobooth dobooth merged commit f938bfb into magento:master Nov 19, 2019
@ghost
Copy link

ghost commented Nov 19, 2019

Hi @k4emic, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Partner: Vaimo partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced JS Bundling examples can lead to problems with JS execution
4 participants