This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keharper
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending some minor grammatical edits.
Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Editorial fix Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
running tests |
running tests |
…to ds_rm-remote-markdown
running tests |
Hi @dshevtsov, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Site Improvements
Updates to tools, processes, and site architecture that improve reader and contributor experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request removes a liquid tag
remote_markdown
completely from the project. Each usage was replaced with a hyperlink to the actual code.Affected pages
Removing the topics that were entirely consisted of the content included by
remote_markdown
:Links to the topics replaced with links to original READMEs in the magento/magento2 repository.
Editing topics that contained any use of
remote_markdown
: