Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Remove remote_markdown completely #6073

Merged
merged 9 commits into from
Nov 26, 2019
Merged

Remove remote_markdown completely #6073

merged 9 commits into from
Nov 26, 2019

Conversation

dshevtsov
Copy link
Collaborator

@dshevtsov dshevtsov commented Nov 26, 2019

Purpose of this pull request

This pull request removes a liquid tag remote_markdown completely from the project. Each usage was replaced with a hyperlink to the actual code.

Affected pages

Removing the topics that were entirely consisted of the content included by remote_markdown:

Links to the topics replaced with links to original READMEs in the magento/magento2 repository.

Editing topics that contained any use of remote_markdown:

  • guides/v2.2/mrg/ce/Sales.md
  • guides/v2.2/mtf/mtf_entities/mtf_constraint.md
  • guides/v2.2/mtf/mtf_entities/mtf_dataset.md
  • guides/v2.2/mtf/mtf_entities/mtf_handler.md
  • guides/v2.2/mtf/mtf_entities/mtf_scenariotest.md
  • guides/v2.2/test/integration/annotations/magento-data-fixture.md
  • guides/v2.3/test/integration/annotations/magento-data-fixture.md

@dshevtsov dshevtsov added the Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience label Nov 26, 2019
@dshevtsov dshevtsov requested a review from a team November 26, 2019 16:07
@dshevtsov dshevtsov self-assigned this Nov 26, 2019
@keharper keharper self-requested a review November 26, 2019 17:57
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending some minor grammatical edits.

dshevtsov and others added 5 commits November 26, 2019 12:42
Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Editorial fix

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov dshevtsov merged commit b8d76c7 into master Nov 26, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov dshevtsov deleted the ds_rm-remote-markdown branch November 26, 2019 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants