Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Dec 11, 2019

Purpose of this pull request

This pull request (PR) fixes #5924.

Affected DevDocs pages

Links to Magento source code

  • ...

Thank you!

whatsnew
Added clarification about required component files to the Extension Developer Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@dobooth dobooth added 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Dec 12, 2019
@shrielenee shrielenee requested a review from osrecio December 12, 2019 19:13
@shrielenee
Copy link
Contributor

These will likely need a technical review, as it contains a newly created include.

@jeff-matthews
Copy link
Contributor

@osrecio, waiting for your review.

Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Technical Point of view this PR is valid. maybe some syntax can be fixed

@jeff-matthews
Copy link
Contributor

running tests

@ghost
Copy link

ghost commented Jan 2, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add clarification to required files in About component file structure page

7 participants