Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#7366: GraphQL: Document password change mutations. Mutation: resetPassword. #7426

Merged
merged 3 commits into from
Jun 22, 2020
Merged

magento/devdocs#7366: GraphQL: Document password change mutations. Mutation: resetPassword. #7426

merged 3 commits into from
Jun 22, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jun 17, 2020 •
edited by keharper
Loading

Purpose of this pull request

This pull request (PR) adds a new topic about resetPassword mutation in scope of #7364.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added the resetPassword mutation.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@atwixfirster atwixfirster changed the base branch from master to 2.4.1-develop June 17, 2020 18:49
@atwixfirster atwixfirster requested a review from dmytro-ch June 17, 2020 18:49
This was referenced Jun 17, 2020
Merged
Closed
@keharper keharper added 2.4.1 Community Docs impacted by community code contribution New Topic A major update published as an entirely new document labels Jun 18, 2020
keharper
keharper suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will not pass our quality checks because it contains links to the requestPasswordResetEmail mutation, which does not exist in this branch.

Meanwhile, #7424 will not pass our quality because it contains links to resetPassword, which does not exist in that branch.

Since I already approved #7424, comment out the references to requestPasswordResetEmail here. I will then merge this PR first. After I merge this PR, update #7424 by restoring the text that was commented out.

src/guides/v2.4/graphql/mutations/reset-password.md Outdated
Argument | Type | Description
--- | --- | ---
`email` | String! | Specifies the customer account that needs a password reset
`resetPasswordToken` | String! | A runtime token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this token come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from email.... or from customer_entity.rp_token

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Could you please review?

src/guides/v2.4/graphql/mutations/reset-password.md Outdated
`newPassword` | String! | The new password

{:.bs-callout-info}
Your new password must be six or more characters in length without spaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the value of Customers > Customer Configuration > Password Options > Minimum Password Length determine this? Would it be better to say that the new password must meet the password policies set for the store?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

fixed

@atwixfirster atwixfirster force-pushed the issue-7364-resetPassword branch from b2c079a to d50316e Compare June 18, 2020 07:02
@keharper
Copy link
Contributor

Since this PR is still waiting for a technical review, I commented out the links to resetPassword in #7424 so that the PR can be merged.

In this PR, update src/guides/v2.4/graphql/mutations/request-password-reset-email.md by uncommenting those links.

@rogyar rogyar self-assigned this Jun 18, 2020
rogyar
rogyar approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster good job!

@keharper
Copy link
Contributor

@atwixfirster I need you to fix the links to this topic as described previously.

@atwixfirster
magento#7366: GraphQL: Document password change mutations. Mutation: …
832e134 
…resetPassword.

- https://devdocs.magento.com/guides/v2.4/graphql/mutations/reset-password.html

Merge remote-tracking branch 'upstream/2.4.1-develop' into issue-7364-resetPassword
@atwixfirster
Copy link
Contributor Author

@atwixfirster I need you to fix the links to this topic as described previously.

done

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit e7424f2 into magento:2.4.1-develop Jun 22, 2020
@ghost
Copy link

ghost commented Jun 22, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

@keharper keharper keharper approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@rogyar rogyar

@keharper keharper

@dmytro-ch dmytro-ch

Labels
2.4.1 Community Docs impacted by community code contribution New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atwixfirster @devops-devdocs @keharper @rogyar @dmytro-ch @magento-engcom-team