Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#7364: Update the storeConfig query to include the new attributes #7431

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jun 19, 2020

Purpose of this pull request

This pull request (PR) updates storeConfig query with customer configuration settings.

The customer attributes were added in magento/magento2#27876

Affected DevDocs pages

Links to Magento source code

whatsnew
Updated the GraphQL storeConfig query to include new customer configuration settings.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

rogyar
rogyar previously requested changes Jun 20, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atwixfirster. Thank you for your collaboration. Please, check my comments below

@@ -185,6 +175,36 @@ The following query returns information about the store's catalog configuration.
}
```

### Query a store's Customer configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep the style the same for all titles

Suggested change
### Query a store's Customer configuration
### Query a store's customer configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -301,6 +321,16 @@ Attribute | Data Type | Description | Example
`root_category_id` | Int | The ID of the root category
`title_separator` | String | Identifies the character that separates the category name and subcategory in the browser title bar | `-`

### Supported Catalog attributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Supported Catalog attributes
### Supported catalog attributes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, it's rather about the customer attributes than the catalog attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment on lines 186 to 191
storeConfig {
autocomplete_on_storefront,
minimum_password_length,
required_character_classes_number,
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's save some chars 😎

Suggested change
storeConfig {
autocomplete_on_storefront,
minimum_password_length,
required_character_classes_number,
}
}
storeConfig {
autocomplete_on_storefront
minimum_password_length
required_character_classes_number
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed :)

fixed


Use the `customer` attributes to retrieve information about the store's customer settings. These attributes are defined in the `CustomerGraphQl` module.

Attribute | Data Type | Description | Configuration path | Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rename the "Example" column to "Default Value" or so, to reflect the actual purpose of the column.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rogyar rogyar added Technical Updates to the code or processes that alter the technical content of the doc Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes labels Jun 20, 2020
@atwixfirster atwixfirster force-pushed the issue-7364-storeConfig branch from e9dc84a to 28a0711 Compare June 20, 2020 09:46
@atwixfirster
Copy link
Contributor Author

@rogyar , all your suggestions have been implemented!

Could you please verify and bless this PR?

Thank you!

@keharper
Copy link
Contributor

running tests

@keharper keharper added Community Docs impacted by community code contribution and removed Technical Updates to the code or processes that alter the technical content of the doc labels Jun 23, 2020
@keharper keharper dismissed rogyar’s stale review June 23, 2020 13:17

Dismissing review because author has responded to all requests

@keharper keharper merged commit 7222ce5 into magento:2.4.1-develop Jun 23, 2020
@ghost
Copy link

ghost commented Jun 23, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Community Docs impacted by community code contribution Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants