-
Notifications
You must be signed in to change notification settings - Fork 1.8k
magento/devdocs#7364: Update the storeConfig query to include the new attributes #7431
magento/devdocs#7364: Update the storeConfig query to include the new attributes #7431
Conversation
An admin must run tests on this PR before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atwixfirster. Thank you for your collaboration. Please, check my comments below
@@ -185,6 +175,36 @@ The following query returns information about the store's catalog configuration. | |||
} | |||
``` | |||
|
|||
### Query a store's Customer configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to keep the style the same for all titles
### Query a store's Customer configuration | |
### Query a store's customer configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -301,6 +321,16 @@ Attribute | Data Type | Description | Example | |||
`root_category_id` | Int | The ID of the root category | |||
`title_separator` | String | Identifies the character that separates the category name and subcategory in the browser title bar | `-` | |||
|
|||
### Supported Catalog attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Supported Catalog attributes | |
### Supported catalog attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, it's rather about the customer attributes than the catalog attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
storeConfig { | ||
autocomplete_on_storefront, | ||
minimum_password_length, | ||
required_character_classes_number, | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's save some chars 😎
storeConfig { | |
autocomplete_on_storefront, | |
minimum_password_length, | |
required_character_classes_number, | |
} | |
} | |
storeConfig { | |
autocomplete_on_storefront | |
minimum_password_length | |
required_character_classes_number | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed :)
fixed
|
||
Use the `customer` attributes to retrieve information about the store's customer settings. These attributes are defined in the `CustomerGraphQl` module. | ||
|
||
Attribute | Data Type | Description | Configuration path | Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rename the "Example" column to "Default Value" or so, to reflect the actual purpose of the column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
e9dc84a
to
28a0711
Compare
@rogyar , all your suggestions have been implemented! Could you please verify and bless this PR? Thank you! |
running tests |
Dismissing review because author has responded to all requests
Hi @atwixfirster, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) updates
storeConfig
query with customer configuration settings.The customer attributes were added in magento/magento2#27876
Affected DevDocs pages
Links to Magento source code
whatsnew
Updated the GraphQL
storeConfig
query to include new customer configuration settings.