Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update the linting workflow on GitHub #8405

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Update the linting workflow on GitHub #8405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d8181
Delete main.yml
dshevtsov Dec 17, 2020
4931831
Update linter.yml
dshevtsov Dec 17, 2020
121b743
Merge branch 'master' into ds_linters
dshevtsov Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,11 @@ name: Lint Code Base
# https://help.github.com/en/articles/workflow-syntax-for-github-actions
#

#############################
# Start the job on all push #
#############################
###################################
# Start the job on a pull request #
###################################
on:
pull_request:
branches:
- master
- 2.*-develop
pull_request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we run the check on all branches, but we only require a passing check on protected branches, right? We configure that with the repo settings instead of the GitHub Action workflow config.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.


###############
# Set the Job #
Expand Down
22 changes: 0 additions & 22 deletions .github/workflows/main.yml
View file
Open in desktop

This file was deleted.