Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[GraphQL caching] Add support for queries via HTTP GET #229

Closed
paliarush opened this issue Oct 29, 2018 · 1 comment
Closed

[GraphQL caching] Add support for queries via HTTP GET #229

paliarush opened this issue Oct 29, 2018 · 1 comment
Assignees
Labels
framework good first issue Good for newcomers magento-core Epics and issues assigned to Magento core team members. small

Comments

@paliarush
Copy link
Contributor

paliarush commented Oct 29, 2018

Based on the prototype and this commit specifically, add support for GraphQL queries via HTTP GET. Note that GraphQL mutations must still only be supported via HTTP POST.

Changes must be covered with GraphQL functional tests.
(This requires changes to the testing framework, which only supports post.)

@pcvonz
Copy link

pcvonz commented Nov 2, 2018

Small note: Adding the ability to use GET would be great for caching client side via the Cache Storage API.

More info in this issue and this issue.

I'm currently working on caching for the Venia concept and the lack of this functionality has been one of the hurdles for a smooth implementation.

@rogyar rogyar self-assigned this Nov 28, 2018
@naydav naydav added this to the Release: 2.3.1 milestone Dec 12, 2018
@naydav naydav changed the title Add support for queries via HTTP GET [GraphQL caching] Add support for queries via HTTP GET Dec 12, 2018
@naydav naydav modified the milestones: Release: 2.3.1, Release: 2.3.2 Feb 8, 2019
@naydav naydav modified the milestones: Release: 2.3.2, Release: 2.3.3 Feb 20, 2019
@danielrenaud danielrenaud assigned danielrenaud and unassigned rogyar Mar 21, 2019
@avattam06 avattam06 added the magento-core Epics and issues assigned to Magento core team members. label Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework good first issue Good for newcomers magento-core Epics and issues assigned to Magento core team members. small
Projects
None yet
Development

No branches or pull requests

7 participants