Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[BugFix] Fix resolving of image placeholder for Product without images #239

Closed
naydav opened this issue Nov 6, 2018 · 2 comments
Closed
Assignees
Labels
bug Something isn't working Component: CatalogGraphQl

Comments

@naydav
Copy link
Contributor

naydav commented Nov 6, 2018

Steps to reproduce

  1. Create Product without images
  2. Perform query
{
  products (search: "simple-495") {
    items {
      small_image {
        url
      }
    }
  }
}

Actual result:

 "url": "http://graphql.local/static/version1538424577/graphql/_view/en_US/Magento_Catalog/images/product/placeholder/small_image.jpg"

Expected result:

 "url": "http://graphql.local/static/version1538424577/frontend/Magento/luma/en_US/Magento_Catalog/images/product/placeholder/small_image.jpg"

Problem is related to wrong area
Also, need to finish \Magento\GraphQl\Catalog\ProductImageTest::testProductWithoutBaseImage

@VoronoyAlexandr VoronoyAlexandr self-assigned this Nov 11, 2018
@naydav naydav changed the title Fix resolving of image placeholder for Product without images [BugFix] Fix resolving of image placeholder for Product without images Dec 12, 2018
@naydav naydav added this to the Release: 2.3.1 milestone Dec 12, 2018
@naydav naydav added the bug Something isn't working label Feb 12, 2019
@naydav naydav modified the milestones: Release: 2.3.1, Release: 2.3.2 Feb 13, 2019
@naydav
Copy link
Contributor Author

naydav commented Feb 21, 2019

#364

@bchatard
Copy link
Contributor

@naydav I test the patch in the PR #364 and the issue is still present.

The Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Image\Placeholder\Theme class is no more used in the merged version, while it is this class that seemed to make the correction

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Component: CatalogGraphQl
Projects
None yet
Development

No branches or pull requests

5 participants