Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[BugFix] Fix area for image placeholder in graphql response. #364

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented Feb 12, 2019

Description (*)

PR for issue #239 Fix resolving of image placeholder for Product without images.
Changed area to pub media instead "graphql" for placeholder asset.

Fixed Issues (if relevant)

  1. [BugFix] Fix resolving of image placeholder for Product without images #239: Fix resolving of image placeholder for Product without images

Manual testing scenarios (*)

Request:

{
  products (search: "Test") {
    
    items {
        id
        name
      small_image {
        url
      }
    }
  }
}

Response:

{
  "data": {
    "products": {
      "items": [
        {
          "id": 1201,
          "name": "Test",
          "small_image": {
            "url": "http://graphql-ce.loc/pub/media/catalog/product/cache/74c1057f7991b4edb2bc7bdaa94de933/m/a/magento_image.jpg"
          }
        }
      ]
    }
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@naydav
Copy link
Contributor

naydav commented Feb 14, 2019

@VitaliyBoyko
Contains performance degradation

Query multiple products (Catalog GraphQL): 10.7% (mainline = 28 | team = 31) -> DEGRADATION
Query configurable product (Catalog GraphQL): 18.8% (mainline = 32 | team = 38) -> DEGRADATION
Query bundle product (Catalog GraphQL): 18.2% (mainline = 33 | team = 39) -> DEGRADATION
Query grouped product (Catalog GraphQL): 27% (mainline = 37 | team = 47) -> DEGRADATION

Looks like too many requests to load the same placeholder

@magento-engcom-team magento-engcom-team merged commit 228ae14 into 2.3-develop Feb 21, 2019
@ghost
Copy link

ghost commented Feb 21, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants