Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Shipping methods] Support of USPS shipping method #282

Closed
naydav opened this issue Dec 12, 2018 · 2 comments
Closed

[Shipping methods] Support of USPS shipping method #282

naydav opened this issue Dec 12, 2018 · 2 comments
Assignees
@atwixfirster
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Dec 12, 2018 •
edited
Loading

Need to cover USPS shipping method functionality with API-functional tests.
Functionality should be fixed if needed.

Query scheme: app/code/Magento/QuoteGraphQl/etc/schema.graphqls

Testcases:

\Magento\GraphQl\Usps\SetUspsShippingMethodsOnCartTest

Don't forget to enable method in a fixture and disable in rollback fixture.

Example: \Magento\GraphQl\OfflineShipping\SetOfflineShippingMethodsOnCartTest

Additionally: Check do we need additional data or carrier code and method code will be enough
@naydav naydav added this to the Release: 2.3.1 milestone Dec 12, 2018
@naydav naydav self-assigned this Dec 12, 2018
@naydav naydav changed the title USPS shipping method during order creating [Shipping methods] USPS shipping method during order creating Dec 12, 2018
@naydav naydav changed the title [Shipping methods] USPS shipping method during order creating [Shipping methods] Support of USPS shipping method during order creating Dec 12, 2018
@naydav naydav changed the title [Shipping methods] Support of USPS shipping method during order creating [Shipping methods] Support of USPS shipping method Dec 12, 2018
@naydav naydav modified the milestones: Release: 2.3.2, Release: 2.3.3 Feb 20, 2019
@rogyar rogyar self-assigned this Feb 21, 2019
@rogyar rogyar mentioned this issue Feb 21, 2019
Merged
@naydav naydav unassigned naydav and rogyar Mar 15, 2019
@naydav naydav added Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers labels Mar 15, 2019
@atwixfirster
Copy link
Contributor

@naydav , could you please assist here?

USPS module requires "User ID" and "Password". Does Magento have a test USPS account for such purpose?

Thank you!

CC: @rogyar @sergiy-v

@atwixfirster atwixfirster self-assigned this Mar 20, 2019
@atwixfirster atwixfirster mentioned this issue Mar 26, 2019
Merged
@atwixfirster
Copy link
Contributor

Pull request: #537

Thank you!

atwixfirster added a commit that referenced this issue Mar 28, 2019
@atwixfirster
#282: [Shipping methods] Support of USPS shipping method
e7139c9
atwixfirster added a commit that referenced this issue Mar 28, 2019
@atwixfirster
#282: [Shipping methods] Support of USPS shipping method
797211c 
Merge remote-tracking branch 'origin/2.3-develop' into 282-shipping-methods-USPS
atwixfirster added a commit that referenced this issue Mar 29, 2019
@atwixfirster
#282: Shipping methods USPS
ec36220
atwixfirster added a commit that referenced this issue Apr 16, 2019
@atwixfirster
#282: Shipping methods USPS
cb22adf 
Merge remote-tracking branch 'origin/2.3-develop' into 282-shipping-methods-USPS
atwixfirster added a commit that referenced this issue Apr 17, 2019
@atwixfirster
#282: Shipping methods USPS
5cd5f04 
Merge remote-tracking branch 'origin/2.3-develop' into 282-shipping-methods-USPS
atwixfirster added a commit that referenced this issue Apr 17, 2019
@atwixfirster
#282: [Shipping methods] Support of USPS shipping method
3b5096c
@naydav naydav modified the milestones: Release: 2.3.3, Release: 2.3.2 Apr 30, 2019
@naydav naydav closed this as completed Apr 30, 2019
atwixfirster added a commit that referenced this issue May 1, 2019
@atwixfirster
#282: [Shipping methods] Support of USPS shipping method
94a8c40 
Merge remote-tracking branch 'origin/2.3-develop' into 282-shipping-methods-USPS
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atwixfirster atwixfirster

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
4 participants
@naydav @rogyar @atwixfirster @misha-kotov