Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Checkout] Rename increment_id for CustomerOrder type #878

Closed
joni-jones opened this issue Aug 30, 2019 · 2 comments
Closed

[Checkout] Rename increment_id for CustomerOrder type #878

joni-jones opened this issue Aug 30, 2019 · 2 comments
Labels
Architects: approved Issue is checked and approved by architecture team. Component: SalesGraphQl documentation-completed good first issue Good for newcomers
Milestone
Release: 2.3.4

Comments

@joni-jones
Copy link
Contributor

joni-jones commented Aug 30, 2019 •
edited by paliarush
Loading

Summary

The CustomerOrder type has increment_id field which represents order number on the storefront. The backend service contracts use this field as is but for the storefront API doesn't have business logic for it and the most usage - show to customer the number of the order.

Acceptance Criteria

  • Deprecate increment_id in CustomerOrder type
  • Introduce order_number: String! in CustomerOrder type
  • Cover with tests
@lenaorobei
Copy link
Contributor

AC:

  • if this field was already released, it is marked as deprecated instead of removing
  • covered with api-functional tests

@lenaorobei lenaorobei removed the good first issue Good for newcomers label Sep 16, 2019
@paliarush paliarush added the Architects: approved Issue is checked and approved by architecture team. label Sep 19, 2019
@lenaorobei lenaorobei added the good first issue Good for newcomers label Sep 20, 2019
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Sep 20, 2019
@strell strell self-assigned this Sep 21, 2019
@okorshenko
Copy link
Contributor

okorshenko commented Sep 21, 2019 •
edited
Loading

@strell \Magento\GraphQl\Sales\OrdersTest

Example: XxXgeoXxX@2c4adbf

strell added a commit to strell/graphql-ce that referenced this issue Sep 21, 2019
@strell
magento#878 - Deprecated the column increment_id
746038e 
 - Added new column order_number with the type of String!
 - Changed the api_functional test in order to test a new field
@strell strell mentioned this issue Sep 21, 2019
Merged
4 tasks
strell added a commit to strell/graphql-ce that referenced this issue Sep 21, 2019
@strell
magento#878 - fixed api - functional test
225c9f7
magento-engcom-team added a commit that referenced this issue Sep 25, 2019
@magento-engcom-team
ENGCOM-5930: #878 - Deprecated the column increment_id #951
bcc5890 
 - Merge Pull Request #951 from strell/graphql-ce:2.3-develop-878
 - Merged commits:
   1. 746038e
   2. 225c9f7
magento-engcom-team pushed a commit that referenced this issue Sep 25, 2019
@lenaorobei
ENGCOM-5930: #878 - Deprecated the column increment_id #951
452b2e3
magento-engcom-team added a commit that referenced this issue Sep 25, 2019
@magento-engcom-team
🔃 [Magento Community Engineering] Community Contributions - GraphQL d…
267db35 
…aily delivery

Accepted Community Pull Requests:
 - #953: Rename PayflowProToken Type (by @pmclain)
 - #952: Add Store Name to Config Schema (by @pmclain)
 - #959: GraphQL-879 Change description for createBraintreeClientToken mutation (by @karyna-tsymbal-atwix)
 - #951: #878 - Deprecated the column increment_id (by @strell)
 - #949: #948 - Move preference for ErrorHandlerInterface (by @vpodorozh)


Fixed GitHub Issues:
 - magento/magento2#881: Installation with sample data failing (reported by @jameswithers) has been fixed in #953 by @pmclain in 2.3-develop branch
   Related commits:
     1. 17ea087

 - magento/magento2#926: Failed due to line endings (reported by @snky1987) has been fixed in #952 by @pmclain in 2.3-develop branch
   Related commits:
     1. 5b32e8e

 - magento/magento2#878: CMS page is not editable (reported by @shivkumarsingh7) has been fixed in #951 by @strell in 2.3-develop branch
   Related commits:
     1. 746038e
     2. 225c9f7

 - magento/magento2#948: varnish cache - odd states, price update question (reported by @robfico) has been fixed in #949 by @vpodorozh in 2.3-develop branch
   Related commits:
     1. fda524e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Architects: approved Issue is checked and approved by architecture team. Component: SalesGraphQl documentation-completed good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
6 participants
@strell @joni-jones @okorshenko @paliarush @keharper @lenaorobei