'small_image' in 'ProductInterface' does not have enough info

[DrewML]

Preconditions

1. 2.3-develop branch

Steps to reproduce

1. Using /graphql, POST a query that requests the small_image for a product
2. The string returned for the small_image field will be in the format /m/b/mb02-gray-0.jpg.
3. The format returned does not have enough information for a client-rendered Magento application to append the uri to an img tag. The returned format is https://mmnl.test/media/catalog/product/cache/2765542505660baab28ecd555e27366e/m/b/mb02-gray-0.jpg

Expected result

1. small_image (and other image values in the ProductInterface) should return a URL that can be used as-is to fetch the associated image

Actual result

1. small_image is populated with a value that can not be used without obtaining other info about cache configuration.

AC:

• Rename small_image to small_image_url and return URL in the following format https://mmnl.test/media/catalog/product/cache/2765542505660baab28ecd555e27366e/m/b/mb02-gray-0.jpg
• [Optional] Fix existing GraphQL tests. See \Magento\GraphQl\Catalog\ProductViewTest::testQueryAllFieldsSimpleProduct as an example.

[jissereitsma]

Perhaps there simply needs to come a second property small_image_url because you could argue that the image stays the same, while the URL might change depending on media URL settings. The problem here is that the GraphQL schema refers to the generic ProductInterface of the catalog module, which counts as @api. I've tried to fix things there, but that leads to a lot of work.

An easier solution would simply be to use a variable media_url within PWA? What I've now done for myself is create a new file src/config.json with a JSON string {"media_url": "/media/catalog/product/"}. Next, in the component where a real URL is needed, I import this JSON (import config from 'src/config.json';) and I construct the URL itself using config.media_url + small_image. Works for me.