Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Customer] Rename dob to date_of_birth #911

Closed
paliarush opened this issue Sep 6, 2019 · 0 comments
Closed

[Customer] Rename dob to date_of_birth #911

paliarush opened this issue Sep 6, 2019 · 0 comments
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl documentation-completed good first issue Good for newcomers
Milestone
Release: 2.3.4

Comments

@paliarush
Copy link
Contributor

Acceptance criteria:

  • dob field should be deprecated in Customer and CustomerInput. Since input types do not natively support deprecation, deprecate via comments
  • Introduce a replacement field called date_of_birth
  • Adjust web API tests to use new field instead of the old one
@XxXgeoXxX XxXgeoXxX self-assigned this Sep 10, 2019
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 10, 2019
@XxXgeoXxX
[Customer] Rename dob to date_of_birth magento#911
fa8f566
@XxXgeoXxX XxXgeoXxX mentioned this issue Sep 10, 2019
Merged
4 tasks
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 12, 2019
@XxXgeoXxX
[Customer] Rename dob to date_of_birth magento#911
aaee0c8
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 17, 2019
@XxXgeoXxX
[Customer] Rename dob to date_of_birth magento#911
e9879d1
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 17, 2019
@XxXgeoXxX
[Customer] Rename dob to date_of_birth magento#911
da62bd1
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Sep 17, 2019
@lenaorobei lenaorobei added the Architects: approved Issue is checked and approved by architecture team. label Sep 17, 2019
lenaorobei added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 20, 2019
@lenaorobei
magento#911: [Customer] Rename dob to date_of_birth
2c4adbf
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 27, 2019
@XxXgeoXxX
[Customer] Rename dob to date_of_birth magento#911
33d8148
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 27, 2019
@XxXgeoXxX
[Customer] Rename dob to date_of_birth magento#911
adb6517
lenaorobei added a commit to XxXgeoXxX/graphql-ce that referenced this issue Oct 1, 2019
@lenaorobei
magento#911: [Customer] Rename dob to date_of_birth
f52ba88
magento-engcom-team added a commit that referenced this issue Oct 2, 2019
@magento-engcom-team
ENGCOM-5985: [Customer] Rename dob to date_of_birth #911 #919
84870f6 
 - Merge Pull Request #919 from XxXgeoXxX/graphql-ce:2.3-develop#911
 - Merged commits:
   1. fa8f566
   2. aaee0c8
   3. e9879d1
   4. da62bd1
   5. 2c4adbf
   6. d167013
   7. 33d8148
   8. adb6517
   9. f52ba88
magento-engcom-team pushed a commit that referenced this issue Oct 2, 2019
@lenaorobei
ENGCOM-5985: [Customer] Rename dob to date_of_birth #911 #919
f3d15ea
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Architects: approved Issue is checked and approved by architecture team. Component: CustomerGraphQl documentation-completed good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
4 participants
@paliarush @keharper @lenaorobei @XxXgeoXxX