Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Wishlist] Remove name from WishlistOutput #920

Closed
paliarush opened this issue Sep 10, 2019 · 0 comments
Closed

[Wishlist] Remove name from WishlistOutput #920

paliarush opened this issue Sep 10, 2019 · 0 comments
Labels
Architects: approved Issue is checked and approved by architecture team. Component: WishlistGraphQl documentation-completed good first issue Good for newcomers
Milestone
Release: 2.3.4

Comments

@paliarush
Copy link
Contributor

paliarush commented Sep 10, 2019 •
edited
Loading

Acceptance Criteria:

  1. Create new type Wishlist based on WishlistOutput. Do not include name field to the new Wishlist. This field is related to Commerce functionality and is always null in Open source edition
  2. Deprecate all fields in WishlistOutput and add comment to the type itself that Wishlist type should be used instead (@deprecated is not supported for types, only for fields)
  3. Add field wishlists: [Wishlist]! to the Customer and implement corresponding resolver. It should be an array to allow for extension in Commerce edition with multiple wishlist functionality
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Sep 10, 2019
@lenaorobei lenaorobei removed the good first issue Good for newcomers label Sep 16, 2019
@melnikovi melnikovi added the Architects: approved Issue is checked and approved by architecture team. label Sep 17, 2019
@lenaorobei lenaorobei added the good first issue Good for newcomers label Sep 18, 2019
@XxXgeoXxX XxXgeoXxX self-assigned this Sep 20, 2019
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 23, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
1d841c3
@XxXgeoXxX XxXgeoXxX mentioned this issue Sep 23, 2019
Merged
4 tasks
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 25, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
7d03bdc
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 26, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
7d4a306
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 27, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
4c85d84
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Sep 27, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
b52fe3e
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Oct 18, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
0977e94
XxXgeoXxX added a commit to XxXgeoXxX/graphql-ce that referenced this issue Oct 18, 2019
@XxXgeoXxX
[Wishlist] Remove name from WishlistOutput magento#920
bff6344
lenaorobei added a commit to XxXgeoXxX/graphql-ce that referenced this issue Oct 24, 2019
@lenaorobei
magento#920: [Wishlist] Remove name from WishlistOutput
282b09b
magento-engcom-team added a commit that referenced this issue Nov 1, 2019
@magento-engcom-team
ENGCOM-6165: [Wishlist] Remove name from WishlistOutput #920 #957
d0891fc 
 - Merge Pull Request #957 from XxXgeoXxX/graphql-ce:2.3-develop#920
 - Merged commits:
   1. 1d841c3
   2. 7d03bdc
   3. 7d4a306
   4. c92ecf8
   5. 4c85d84
   6. b52fe3e
   7. 0977e94
   8. bff6344
   9. 282b09b
   10. acbc881
   11. 6b443b4
magento-engcom-team pushed a commit that referenced this issue Nov 1, 2019
@lenaorobei
ENGCOM-6165: [Wishlist] Remove name from WishlistOutput #920 #957
1fba468
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Architects: approved Issue is checked and approved by architecture team. Component: WishlistGraphQl documentation-completed good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
5 participants
@melnikovi @paliarush @keharper @lenaorobei @XxXgeoXxX