Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

hidden product attributes not intended for storefront #103

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

vovsky
Copy link
Contributor

@vovsky vovsky commented Jun 30, 2018

Description

Hidden product attributes not intended for storefront

Fixed Issues

  1. Hide product attributes not intended for storefront #25 Hide product attributes not intended for storefront

Manual testing scenarios

  1. Add custom EAV product attribute with the following properties set to NO : 'is_comparable', 'is_filterable', 'is_filterable_in_search', 'is_visible_on_front', 'used_in_product_listing', 'used_for_sort_by'
  2. Refresh cache
  3. Attribute should not be visible in graphql

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 30, 2018

CLA assistant check
All committers have signed the CLA.

@paliarush paliarush added the requires-tests PRs which require GraphQL tests label Jul 2, 2018
@keharper
Copy link
Contributor

keharper commented Jul 2, 2018

We'll need to add a place in the docs where we list the Admin settings that affect graphQL query results.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants