Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

#1029 Add Postcode as required depending of the country Mutation createCustomerAddress #1031

Merged
merged 3 commits into from
Nov 14, 2019
Merged

#1029 Add Postcode as required depending of the country Mutation createCustomerAddress #1031

merged 3 commits into from
Nov 14, 2019

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Oct 27, 2019 •
edited by okorshenko
Loading

Description (*)

Adding a validation with country and postcode to set is required for the mutation createCustomerAddress

Fixed Issues (if relevant)

  1. Postcode is not listed in the array of errors #1029: Postcode is not listed in the array of errors

Manual testing scenarios (*)

  1. Described in: Postcode is not listed in the array of errors #1029

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [] All new or changed code is covered with unit/integration tests (if applicable)
  • [] All automated tests passed successfully (all builds are green)

@osrecio osrecio force-pushed the 1029-postcode-required-customerCreate branch 2 times, most recently from 20e0aac to 216e4b9 Compare October 27, 2019 12:08
@osrecio osrecio force-pushed the 1029-postcode-required-customerCreate branch from 216e4b9 to 676cd1b Compare October 27, 2019 12:10
@okorshenko
Copy link
Contributor

Hi @osrecio
It would be great to cover this change with GraphQL test

@okorshenko
Copy link
Contributor

💡New dependency on Magento\Directory module should be approved via Magento Approval Request. It is pre-approved right now with @maghamed during the contribution day. Customer module does not have the proper API to execute this logic.

@osrecio osrecio requested a review from buskamuza as a code owner October 27, 2019 13:27
osrecio
osrecio commented Oct 27, 2019
View reviewed changes
app/code/Magento/CustomerGraphQl/composer.json
@@ -4,15 +4,15 @@
"type": "magento2-module",
"require": {
"php": "~7.1.3||~7.2.0||~7.3.0",
"magento/module-customer": "*",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted because is duplicated

@TomashKhamlai TomashKhamlai added QA in progress We are checking QA passed and removed QA in progress We are checking labels Oct 28, 2019
@TomashKhamlai
Copy link
Contributor

Please take a look at Case 3 in #1032

@lenaorobei
Copy link
Contributor

@osrecio could you please address the failed test case found by @TomashKhamlai. Thank you.

@osrecio osrecio requested a review from paliarush as a code owner November 8, 2019 19:34
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6255 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team mentioned this pull request Nov 14, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Nov 14, 2019
@lenaorobei
ENGCOM-6255: #1029 Add Postcode as required depending of the country …
ba44d97 
…Mutation createCustomerAddress #1031
@magento-engcom-team magento-engcom-team merged commit 891e5a4 into magento:2.3-develop Nov 14, 2019
@ghost
Copy link

ghost commented Nov 14, 2019

Hi @osrecio, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@buskamuza buskamuza Awaiting requested review from buskamuza

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@osrecio osrecio

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Component: CustomerGraphQl Partner: Interactiv4 partners-contribution QA passed Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@osrecio @okorshenko @TomashKhamlai @lenaorobei @magento-engcom-team