Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

magento/graphql-ce#: Add missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest #1051

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

atwixfirster
Copy link
Contributor

Description (*)

PR adds missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest + misspelling fix.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@atwixfirster atwixfirster changed the title magento/graphql-ce#: Add missed annotation block to Magento\GraphQl\Customer\CreateCustomerTest magento/graphql-ce#: Add missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest Nov 6, 2019
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atwixfirster. The use of @inheritdoc is in general discouraged. Please see the reference - https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html#inheritdoc. For tiny cleanup fixes please combine into 1 PR. It should contain fixes for at leas all Customer tests. Thank you.

@atwixfirster
Copy link
Contributor Author

Hi @atwixfirster. The use of @inheritdoc is in general discouraged. Please see the reference - https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html#inheritdoc. For tiny cleanup fixes please combine into 1 PR. It should contain fixes for at leas all Customer tests. Thank you.

@lenaorobei , I have updated the descriptions. Could you please verify? Thanks

@lenaorobei
Copy link
Contributor

As per documentation: A short description in case it adds meaningful information beyond the method name. I believe that methods like setUp already have meaningful description, so additional info not needed.

@lenaorobei
Copy link
Contributor

You can check for other typos in the dev/tests/api-functional/testsuite/Magento/GraphQl/Customer folder. Example: testChangeSubscriptionStatuIfUserIsNotAuthorizedTest.

@atwixfirster atwixfirster force-pushed the mutation-CreateCustomer branch 2 times, most recently from 96a0117 to 66095a5 Compare November 6, 2019 17:30
@atwixfirster atwixfirster force-pushed the mutation-CreateCustomer branch from 66095a5 to b904c63 Compare November 6, 2019 17:41
@atwixfirster
Copy link
Contributor Author

You can check for other typos in the dev/tests/api-functional/testsuite/Magento/GraphQl/Customer folder.

done

Thank you, @lenaorobei

@lenaorobei
Copy link
Contributor

@magento run Database Compare

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6245 has been created to process this Pull Request

@lenaorobei lenaorobei added this to the Release: 2.3.5 milestone Nov 13, 2019
@magento-engcom-team magento-engcom-team merged commit b904c63 into 2.3-develop Nov 14, 2019
@ghost
Copy link

ghost commented Nov 14, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants