-
Notifications
You must be signed in to change notification settings - Fork 154
magento/graphql-ce#: Add missed annotation blocks to Magento\GraphQl\Customer\CreateCustomerTest #1051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atwixfirster. The use of @inheritdoc
is in general discouraged. Please see the reference - https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html#inheritdoc. For tiny cleanup fixes please combine into 1 PR. It should contain fixes for at leas all Customer
tests. Thank you.
93e2a86
to
b63e5f2
Compare
@lenaorobei , I have updated the descriptions. Could you please verify? Thanks |
As per documentation: |
You can check for other typos in the |
96a0117
to
66095a5
Compare
66095a5
to
b904c63
Compare
done Thank you, @lenaorobei |
@magento run Database Compare |
Hi @lenaorobei, thank you for the review. |
Hi @atwixfirster, thank you for your contribution! |
Description (*)
PR adds missed annotation blocks to
Magento\GraphQl\Customer\CreateCustomerTest
+ misspelling fix.Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Thank you!