This repository was archived by the owner on Dec 19, 2019. It is now read-only.
API-functional tests: assertResponseFields moved to the abstract class #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkublytskyi
approved these changes
Jul 26, 2018
added 2 commits
August 15, 2018 16:45
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 26, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Method assertResponseFields is used in 11 different tests. The functionality is absolutely the same, so it makes sense to put it into the abstract class instead of copying it over and over again
Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A