-
Notifications
You must be signed in to change notification settings - Fork 156
Render category description directives #148
Conversation
@rogyar Thanks for contribution, changes look good! |
@rogyar I can not reproduce issue with not all directives being rendered on 2.3-develop, could you please provide steps you use to reproduce it? Thank you. |
Hi @melnikovi, sure. Within a scope of a product description or short_description we can use different directives including inserting blocks/widgets etc. We cannot do the same with category description due to the core template renderer limitations. For example, if you insert in the product's description the following directive:
it's rendered on the storefront (also, in the GraphQL response). |
…ry/Download #148 - Merge Pull Request magento-engcom/import-export-improvements#148 from denispapec/import-export-improvements:phpstan-historydownload - Merged commits: 1. b0240f1 2. 518b4d4
Description
This PR improves output for description of a category. Previously we just had a raw output. Now, if you use some directive (upon uploading an image), its contents are rendered
Fixed Issues (if relevant)
Manual testing scenarios
{media url=...}
Please note, not all directives are supported in the category description on the core level. For example, you cannot insert a block like in #140 . It's not the current implementation limitation but core behavior. If you try to insert a block and check the storefront, it's not rendered there as well. All directives that are supported by default template filter (used on storefront) are also supported in the GraphQL response.