#141 add simple product to cart #170

roma-glushko · 2018-09-04T18:02:22Z

Description

The pull enables adding simple products to customer/guest carts via GraphQl mutations.

In order to add simple product to cart the following information can be passed:

product SKUs (required)
quantities (required)
custom options (required if product has required options)

As a result of executing such mutation, the current state of the cart will be returned. Cart items information can vary and depends on product types. For this case, simple cart item contains information about custom options.

Fixed Issues

Date of birth - year only goes back to 2002 magento2#141: Add simple product to cart

Manual testing scenarios

The following query can be executed to test the changes:

mutation {
  addSimpleProductsToCart(
    input: {
      cart_id: "b96566a020b8797b7d806a948174275e", 
      cartItems: [
        {
          data: {
            sku: "product_dynamic_24494", 
            qty: 1
          }, 
          customizable_options: [
            {id: 5, value: "test"},
            {id: 6, value: "5"}
          ]
        }
      ]
    }
  ) {
    
    cart {
      items {
        id
        qty
        ... on SimpleCartItem {
          customizable_options {
            id
            label
            type
            is_required
            values {
              id
              label
              value
              price {
                type
                units
                value
              }
            }
          }
        }
        product {
          sku
          name
          image
          url_key
          categories {
            id
            name
          } 
          updated_at
          websites {
            name
          }
        }
      }
    }    
  }
}

magento-cicd2 · 2018-09-04T18:02:25Z

All committers have signed the CLA.

paliarush · 2018-09-05T21:26:39Z

app/code/Magento/CatalogGraphQl/README.md

@@ -1,4 +1,4 @@
-# CatalogGraphQl
+# QuoteGraphQl


Looks like accidental change

Indeed. Will fix that. Thank you for noticing!

paliarush · 2018-09-05T21:56:00Z

app/code/Magento/CatalogGraphQl/Model/Product/Option/DateType.php

+/**
+ * Catalog product option date validator
+ */
+class DateType extends ProductDateOptionType


Why is this one needed?

The reason why it's needed is ProductDateOptionType wants to see date value as an associate array (like ['year' => '2018', 'month' => '1', 'day' => '1']). By this changes, we allow to use string as a date value. This meets our schema shape.
The same approach is used in REST API.

paliarush · 2018-09-05T22:13:04Z

app/code/Magento/QuoteGraphQl/Model/Resolver/CartItem/CustomizableOptions.php

+            $optionValue = $option->getValueById($itemOption->getValue());
+            $selectedOptionValueData['price'] = [
+                'type' => strtoupper($optionValue->getPriceType()),
+                'units' => '$',


I believe this part, including files processing will be completed before we merge.

Yes, I have been implemented this mock. Thank you for noticing!

paliarush · 2018-09-05T22:16:06Z

app/code/Magento/QuoteGraphQl/Model/Resolver/CartItemTypeResolverComposite.php

+    {
+        if (!isset($data['product'])) {
+            throw new GraphQlInputException(
+                __('Missing key %1 in cart data', ['product'])


I don't think this error will be useful for the end user. This should probably be a regular \LogicException. Same for the other exception below.

What do you think?

paliarush · 2018-09-05T22:46:37Z

app/code/Magento/QuoteGraphQl/etc/schema.graphqls

+}
+
+type SelectedCustomizableOptionValue {
+    id: Int


Why ID can be null?

It should not be. Changing to id: Int!. Thank you for mentioning!

paliarush · 2018-09-05T22:52:23Z

app/code/Magento/SimpleProductGraphQl/Model/Resolver/Cart/AddSimpleProductsToCart.php

+            $errorMessages[] = $error->getText();
+        }
+
+        return implode(PHP_EOL, $errorMessages);


It is probably better to use semicolon or another separator for the messages in GraphQL output.

paliarush · 2018-09-05T22:53:26Z

app/code/Magento/SimpleProductGraphQl/composer.json

@@ -0,0 +1,26 @@
+{
+    "name": "magento/module-simple-product-graph-ql",


This should be part of CatalogGraphql module since simple product type is defined in Catalog module.

paliarush · 2018-09-05T22:55:34Z

...tests/api-functional/testsuite/Magento/GraphQl/SimpleProduct/AddSimpleProductsToCartTest.php

+QUERY;
+        $response = $this->graphQlQuery($query);
+
+        var_dump($response);


We should not have var_dump in tests.

paliarush · 2018-09-05T22:56:06Z

...tests/api-functional/testsuite/Magento/GraphQl/SimpleProduct/AddSimpleProductsToCartTest.php

+
+        var_dump($response);
+
+        self::assertArrayHasKey('addSimpleProductsToCart', $response);


Would be perfect to validate all the requested fields.

paliarush

Please address review comments above.

naydav · 2018-09-13T12:46:10Z

@roma-glushko
Pls, merge mainline and re-run tests

I found a few problems


FILE: ...pp/code/Magento/CatalogGraphQl/Model/Product/Option/DateType.php
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------
 19 | ERROR | [x] {@inheritdoc} imports only short description,
    |       |     annotation must have long description
 21 | ERROR | [x] {@inheritdoc} does not import parameter annotation
 30 | ERROR | [x] Missing short description
 31 | ERROR | [x] There must be exactly one blank line before tags
 53 | ERROR | [x] Missing short description
 54 | ERROR | [x] There must be exactly one blank line before tags
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ml/app/code/Magento/QuoteGraphQl/Model/Hydrator/CartHydrator.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 15 | ERROR | [x] {@inheritdoc} imports only short description,
    |       |     annotation must have long description
 19 | ERROR | [x] Missing short description
 20 | ERROR | [x] There must be exactly one blank line before tags
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...nto/QuoteGraphQl/Model/Resolver/Cart/AddSimpleProductsToCart.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
  32 | ERROR | [x] {@inheritdoc} imports only short description,
     |       |     annotation must have long description
 115 | ERROR | [x] {@inheritdoc} imports only short description,
     |       |     annotation must have long description
 117 | ERROR | [x] {@inheritdoc} does not import parameter annotation
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...nto/QuoteGraphQl/Model/Resolver/CartItem/CustomizableOptions.php
----------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------
  29 | ERROR | [x] {@inheritdoc} imports only short description,
     |       |     annotation must have long description
  64 | ERROR | [x] {@inheritdoc} imports only short description,
     |       |     annotation must have long description
  66 | ERROR | [x] {@inheritdoc} does not import parameter annotation
 104 | ERROR | [x] Missing short description
 105 | ERROR | [x] There must be exactly one blank line before tags
 209 | ERROR | [x] Missing short description
 210 | ERROR | [x] There must be exactly one blank line before tags
 225 | ERROR | [x] There must be exactly one blank line before tags
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ode/Magento/QuoteGraphQl/Model/Resolver/CartItemTypeResolver.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 14 | ERROR | [x] {@inheritdoc} imports only short description,
    |       |     annotation must have long description
 32 | ERROR | [x] {@inheritdoc} imports only short description,
    |       |     annotation must have long description
 33 | ERROR | [x] There must be exactly one blank line before tags
 33 | ERROR | [x] There must be exactly one blank line between lines
 35 | ERROR | [x] {@inheritdoc} does not import parameter annotation
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...to/QuoteGraphQl/Model/Resolver/CartItemTypeResolverComposite.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 14 | ERROR | [x] {@inheritdoc} imports only short description,
    |       |     annotation must have long description
 32 | ERROR | [x] {@inheritdoc} imports only short description,
    |       |     annotation must have long description
 33 | ERROR | [x] There must be exactly one blank line before tags
 33 | ERROR | [x] There must be exactly one blank line between lines
 35 | ERROR | [x] {@inheritdoc} does not import parameter annotation
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

/var/www/html/app/code/Magento/QuoteGraphQl/Model/Resolver/Cart/AddSimpleProductsToCart.php:34	The class AddSimpleProductsToCart has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
/var/www/html/app/code/Magento/QuoteGraphQl/Model/Resolver/CartItem/CustomizableOptions.php:111	The method getOptionData() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
/var/www/html/app/code/Magento/QuoteGraphQl/Model/Resolver/CartItem/CustomizableOptions.php:111	The method getOptionData() has an NPath complexity of 720. The configured NPath complexity threshold is 200.

-- fix static builds

-- fix static tests

…-product-to-cart

-- fix static tests

MC-6436

roma-glushko added in-progress Partner: Atwix Component: Quote labels Sep 4, 2018

paliarush reviewed Sep 5, 2018

View reviewed changes

paliarush suggested changes Sep 5, 2018

View reviewed changes

Roman Glushko added 2 commits September 7, 2018 14:47

#141 Added add simple product to cart mutation to quote-graphql module

eea5cdd

#141 Added required configurations

50a928c

roma-glushko force-pushed the 141-add-simple-product-to-cart branch from 36f075c to 50a928c Compare September 7, 2018 12:35

roma-glushko changed the base branch from 2.3-develop to GraphQL-165 September 7, 2018 12:46

Roman Glushko added 3 commits September 7, 2018 16:32

#141 Added hard dependencies

5105989

#141 Fixed issues from Travis

1734dfc

#141 Running tests again

7e7e82c

roma-glushko removed the in-progress label Sep 13, 2018

naydav changed the base branch from GraphQL-165 to 2.3-develop September 13, 2018 10:36

magento-engcom-team assigned naydav Sep 13, 2018

magento-engcom-team added this to the Release: 2.3.0 milestone Sep 13, 2018

magento-engcom-team added Release Line: 2.3 partners-contribution and removed Component: Quote labels Sep 13, 2018

naydav added the Imported label Sep 13, 2018

naydav added Special Achievement Award: special achievement Award: complex and removed Complex PR labels Sep 25, 2018

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

7990b83

naydav force-pushed the 141-add-simple-product-to-cart branch from 3f3556d to 7990b83 Compare September 26, 2018 16:10

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

ada51dc

magento-engcom-team modified the milestones: Release: 2.3.0, Release: 2.3.1 Sep 26, 2018

Valeriy Nayda added 4 commits September 26, 2018 19:53

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

484c65c

-- fix static builds

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

6b7300a

-- fix static builds

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

c21a016

-- fix static tests

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

d39230e

-- fix static tests

naydav added the Imported label Sep 27, 2018

Valeriy Nayda added 4 commits October 1, 2018 12:48

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

d43164b

-- fix static tests

Merge remote-tracking branch 'origin/2.3-develop' into 141-add-simple…

fa5940a

…-product-to-cart

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

c78b993

-- fix static tests

GraphQL-141: [Mutations] Cart Operations > Add simple product to Cart

7e3c023

-- fix static tests

magento-engcom-team merged commit 7e3c023 into 2.3-develop Oct 3, 2018

magento-engcom-team pushed a commit that referenced this pull request Oct 3, 2018

ENGCOM-2967: #141 add simple product to cart #170

f467d9d

naydav mentioned this pull request Oct 3, 2018

[Cart Operations] Add simple product to Cart #141

Closed

naydav added the requires-tests PRs which require GraphQL tests label Oct 3, 2018

keharper added the requires-documentation label Nov 21, 2018

keharper mentioned this pull request Nov 21, 2018

GraphQL: Add docs for quote endpoint in 2.3.1 magento/devdocs#3337

Closed

12 tasks

naydav removed this from the Release: 2.3.1 milestone Dec 7, 2018

awilcoxa mentioned this pull request Mar 4, 2019

DISCOVERY: PWA 2.0 REST queries to Magento 2.3.1 GraphQL magento/pwa-studio#953

Closed

keharper mentioned this pull request Apr 10, 2019

Docs: Add reference information for updates to QueryGraphQl module #588

Closed

naydav deleted the 141-add-simple-product-to-cart branch April 12, 2019 19:36

magento-engcom-team pushed a commit that referenced this pull request Jul 15, 2019

Merge pull request #170 from magento-pangolin/MC-6436

7e55aca

MC-6436

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#141 add simple product to cart #170

#141 add simple product to cart #170

roma-glushko commented Sep 4, 2018 •

edited by naydav

Loading

magento-cicd2 commented Sep 4, 2018 •

edited

Loading

paliarush Sep 5, 2018

roma-glushko Sep 6, 2018

paliarush Sep 5, 2018

roma-glushko Sep 6, 2018

paliarush Sep 5, 2018

roma-glushko Sep 6, 2018

paliarush Sep 5, 2018 •

edited

Loading

paliarush Sep 5, 2018 •

edited

Loading

roma-glushko Sep 6, 2018

paliarush Sep 5, 2018

paliarush Sep 5, 2018

paliarush Sep 5, 2018

paliarush Sep 5, 2018

paliarush left a comment

naydav commented Sep 13, 2018 •

edited

Loading

		@@ -0,0 +1,26 @@
		{
		"name": "magento/module-simple-product-graph-ql",


		var_dump($response);

		self::assertArrayHasKey('addSimpleProductsToCart', $response);

#141 add simple product to cart #170

#141 add simple product to cart #170

Conversation

roma-glushko commented Sep 4, 2018 • edited by naydav Loading

Description

Fixed Issues

Manual testing scenarios

magento-cicd2 commented Sep 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paliarush Sep 5, 2018 • edited Loading

Choose a reason for hiding this comment

paliarush Sep 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paliarush left a comment

Choose a reason for hiding this comment

naydav commented Sep 13, 2018 • edited Loading

roma-glushko commented Sep 4, 2018 •

edited by naydav

Loading

magento-cicd2 commented Sep 4, 2018 •

edited

Loading

paliarush Sep 5, 2018 •

edited

Loading

paliarush Sep 5, 2018 •

edited

Loading

naydav commented Sep 13, 2018 •

edited

Loading