-
Notifications
You must be signed in to change notification settings - Fork 154
GraphQL-60: Manage Stored Payment Methods #228
GraphQL-60: Manage Stored Payment Methods #228
Conversation
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenAdd.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenAdd.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenAdd.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenAdd.php
Outdated
Show resolved
Hide resolved
The current implementation of Checkout storefront doesn't use token id, the public hash is used instead. I would recommend avoiding the usage of entity id field. |
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentToken/PaymentTokenDataProvider.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentToken/PaymentTokenDataProvider.php
Outdated
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Vault/_files/payment_active_tokens.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfantini thanks for the contribution, please address review comments above.
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenAdd.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenAdd.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenDelete.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenDelete.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenDelete.php
Outdated
Show resolved
Hide resolved
app/code/Magento/VaultGraphQl/Model/Resolver/PaymentTokenList.php
Outdated
Show resolved
Hide resolved
I don't see the point to create GraphQL request to add a new token, most of the payment integrations allow storing the token after authorization transaction and the token might be received only in a server-server call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pfantini All changes after the initial CR look good, thank you.
Please address @joni-jones 's concern and we can merge this PR.
lib/internal/Magento/Framework/Setup/Declaration/Schema/Declaration/SchemaBuilder.php
Outdated
Show resolved
Hide resolved
e3724aa
to
28017ce
Compare
Hi @pfantini, thank you for your contribution! |
Description
#60
Manual testing scenarios
Contribution checklist