[256] Fixed variant collection

[VitaliyBoyko]

Description (*)

This PR fixed empty response for variant in ConfigurableProduct with sample data.

Fixed Issues (if relevant)

1. [BugFix] Configurable products > Variants > Attributes are empty #256: Configurable products > Variants > Attributes are empty

Manual testing scenarios (*)

Request

{
  products(filter: {sku: {eq: "WP13"}}) {
    items {
      name
      ... on ConfigurableProduct {
        sku
        variants {
          product {
            sku
          }
          attributes {
            label
            code
            value_index
          }
        }
      }
    }
  }
}

Response

{
  "data": {
    "products": {
      "items": [
        {
          "name": "Portia Capri",
          "sku": "WP13",
          "variants": [
            {
              "product": {
                "sku": "WP13-28-Blue"
              },
              "attributes": [
                {
                  "label": "Blue",
                  "code": "color",
                  "value_index": 50
                },
                {
                  "label": "28",
                  "code": "size",
                  "value_index": 172
                }
              ]
            },
            {
              "product": {
                "sku": "WP13-28-Green"
              },
              "attributes": [
                {
                  "label": "Green",
                  "code": "color",
                  "value_index": 53
                },
                {
                  "label": "28",
                  "code": "size",
                  "value_index": 172
                }
              ]
            },
            {
              "product": {
                "sku": "WP13-28-Orange"
              },
              "attributes": [
                {
                  "label": "Orange",
                  "code": "color",
                  "value_index": 56
                },
                {
                  "label": "28",
                  "code": "size",
                  "value_index": 172
                }
              ]
            },
            {
              "product": {
                "sku": "WP13-29-Blue"
              },
              "attributes": [
                {
                  "label": "Blue",
                  "code": "color",
                  "value_index": 50
                },
                {
                  "label": "29",
                  "code": "size",
                  "value_index": 173
                }
              ]
            },
            {
              "product": {
                "sku": "WP13-29-Green"
              },
              "attributes": [
                {
                  "label": "Green",
                  "code": "color",
                  "value_index": 53
                },
                {
                  "label": "29",
                  "code": "size",
                  "value_index": 173
                }
              ]
            },
            {
              "product": {
                "sku": "WP13-29-Orange"
              },
              "attributes": [
                {
                  "label": "Orange",
                  "code": "color",
                  "value_index": 56
                },
                {
                  "label": "29",
                  "code": "size",
                  "value_index": 173
                }
              ]
            }
          ]
        }
      ]
    }
  }
}

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[naydav]

@VitaliyBoyko Looks like we need to cover functionality with API-functional test
Thanks

[VitaliyBoyko]

@VitaliyBoyko Looks like we need to cover functionality with API-functional test
Thanks

I've added an additional check if attributes array contains an item.

[naydav]

@VitaliyBoyko
Pls check

Magento.GraphQl.Catalog.CategoryProductsVariantsTest.testGetSimpleProductsFromCategory
Magento.GraphQl.Catalog.CategoryProductsVariantsTest.testGetSimpleProductsFromCategory
-
Failed asserting that actual size 0 matches expected size 2.
-

Magento.GraphQl.ConfigurableProduct.ConfigurableProductViewTest.testQueryConfigurableProductLinks
Magento.GraphQl.ConfigurableProduct.ConfigurableProductViewTest.testQueryConfigurableProductLinks
-
Precondition failed: 'variants' must not be empty
Failed asserting that an array is not empty.
-

these tests are faliled on Jenkins
Thanks

[naydav]

Looks like we have a problem at this place because $value['product']['model'] contains Product model object

[ghost]

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.