Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

263 test coverage for pr 226 #347

Merged
merged 5 commits into from
Feb 14, 2019
Merged

263 test coverage for pr 226 #347

merged 5 commits into from
Feb 14, 2019

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

This PR add API-function tests which cover negative scenarios

Fixed Issues (if relevant)

  1. Test coverage for PR-226 #263: Test coverage for PR-226

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VitaliyBoyko VitaliyBoyko self-assigned this Feb 6, 2019
@VitaliyBoyko VitaliyBoyko requested a review from naydav February 6, 2019 20:21
@VitaliyBoyko VitaliyBoyko assigned naydav and unassigned VitaliyBoyko Feb 6, 2019
@magento-engcom-team magento-engcom-team merged commit 0c6f900 into 2.3-develop Feb 14, 2019
@ghost
Copy link

ghost commented Feb 14, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 14, 2019
@naydav
ENGCOM-4257: 263 test coverage for pr 226 #347
6a63e3b
@naydav naydav mentioned this pull request Feb 14, 2019
Closed
@naydav naydav deleted the 263_test_coverage_for_PR_226 branch April 12, 2019 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@naydav naydav Awaiting requested review from naydav

Assignees

@naydav naydav

Labels
Award: test coverage Partner: Atwix partners-contribution Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitaliyBoyko @naydav @magento-engcom-team @VoronoyAlexandr