GraphQl-644: [Checkout] Support of "Braintree" payment method

[pmclain]

Description (*)

#644

Provides prototype for graphql Braintree and Braintree Vault support. Does not currently include support for Braintree Paypal.

Manual testing scenarios (*)

1. Enable braintree payment method with sandboxed api credentials
2. Create quote with shipping address, billing address, shipping method.
3. Set payment method to braintree using valid sandbox nonce, such as nonce in mutation below:

mutation setPaymentMethod($cartId:String!) {
  setPaymentMethodOnCart(input:{
    cart_id:$cartId
    payment_method:{
      code:"braintree"
      purchase_order_number:"n"
      additional_data:{
        braintree:{
          is_active_payment_token_enabler:false
          payment_method_nonce:"fake-valid-nonce"
        }
      }
    }
  }) {
    cart {
      cart_id
    }
  }
}

4. Trigger order placement of quote following payment method set:

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[naydav]

Hello @pmclain ,
Sorry for the delay with the PR processing.
This functionality will have top priority in 2.3.3 release
Thanks

[joni-jones]

It doesn't make sense to call SetPaymentMethodOnCart and PlaceOrder resolvers separately for Braintree (now it's done because PlaceOrder resolver doesn't set payment details). The current flow does place an order through payment-information REST API call which sets payment information and places the order.

The main problem in two separate calls that some data might be changed during these calls, like fraud fingerprints and the payment data won't be actual anymore.

cc @naydav

[pmclain]

@joni-jones @nadavspi I would like to see a mutation along the lines of setPaymentMethodAndPlaceOrder, but I don't think this PR is the proper forum for that discussion. The current flow of placing the order while setting the payment method is a frontend implementation detail. It's currently possible to set the payment method using the rest API without placing an order if the merchant decides to.

[nadavspi]

You meant to tag @naydav, but I support this too.

[naydav]

@TomashKhamlai please check this ticket
Thanks

[pmclain]

@lenaorobei Thanks for taking a look. This has been updated.

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5527 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ghost]

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.