This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Implement updates all properties in updateCustomer mutation #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
suggested changes
Feb 26, 2019
@@ -19,6 +19,8 @@ | |||
*/ | |||
class UpdateCustomerData | |||
{ | |||
private const RESTRICTED_DATA_KEYS = ['email', 'password']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this data to constructor parameter (values should be set via di)
It more extensible way
BTW maybe we can reuse some data provider for these fields? Do we have the corresponding model in Magento?
Thanks
|
||
if (isset($data['lastname'])) { | ||
$customer->setLastname($data['lastname']); | ||
foreach ($newCustomerData as $key => $value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check can we reuse dataObjectHelper?
The current schema defines properties that were ignored when processing user input. Fixes magento#388
* update how customer object is updated * add di to restrict updating defined properties
Hi @pmclain, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The current schema defines properties that were ignored when processing user
input.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)