This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Extended product customizable options coverage #414
Merged
magento-engcom-team
merged 6 commits into
2.3-develop
from
extended-customizable-options
Mar 6, 2019
Merged
Extended product customizable options coverage #414
magento-engcom-team
merged 6 commits into
2.3-develop
from
extended-customizable-options
Mar 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -323,6 +323,19 @@ type CustomizableDropDownValue @doc(description: "CustomizableDropDownValue defi | |||
sort_order: Int @doc(description: "The order in which the option is displayed") | |||
} | |||
|
|||
type CustomizableMultipleOption implements CustomizableOptionInterface @doc(description: "CustomizableMultipoleOption contains information about a multiselect that is defined as part of a customizable option") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little typo here "Multipole"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Good catch! :)
Hi @rogyar, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR extends customizable options coverage for GraphQl and fixes existing issues with customizable options within a scope of checkout coverage.
New customizable option types coverage for Product query
Fixed Issues (if relevant)
Manual testing scenarios (*)
Product query