This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Test coverage: Set OfflineShipping methods on Cart #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
suggested changes
Mar 6, 2019
...functional/testsuite/Magento/GraphQl/OfflineShipping/SetOfflineShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
...functional/testsuite/Magento/GraphQl/OfflineShipping/SetOfflineShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
...functional/testsuite/Magento/GraphQl/OfflineShipping/SetOfflineShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
...functional/testsuite/Magento/GraphQl/OfflineShipping/SetOfflineShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
...functional/testsuite/Magento/GraphQl/OfflineShipping/SetOfflineShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
| self::assertEquals($addressesInformation[0]['selected_shipping_method']['carrier_code'], $shippingCarrierCode); | ||
| self::assertEquals($addressesInformation[0]['selected_shipping_method']['method_code'], $shippingMethodCode); | ||
| self::assertEquals($addressesInformation[0]['selected_shipping_method']['amount'], $shippingAmount); | ||
| self::assertEquals($addressesInformation[0]['selected_shipping_method']['label'], $shippingLabel); |
There was a problem hiding this comment.
Need to add 'Displayed Error Message' and Sort fields to the scheme as part of available_shipping_methods
There was a problem hiding this comment.
I believe this case is out of scope of the current test since the current test covers setting shipping addresses but not getting available shipping addresses.
I would recommend creating a separate issue for getAvailableShippingMethods coverage.
|
@naydav I've resolved the mentioned changes. Please, take a look when you have some time. Thank you |
naydav
added
in-progress
Progress: ready for review
and removed
Progress: needs update
in-progress
labels
|
Hi @rogyar, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR introduces test coverage for setting offline shipping methods for the shopping cart.
Fixed Issues (if relevant)