Resolve coupling between objects in \Magento\QuoteGraphQl\Model\Cart\SetBillingAddressOnCart

[vasilii-b]

Description (*)

Fixed issue #468

Fixed Issues (if relevant)

1. Resolve coupling between objects in \Magento\QuoteGraphQl\Model\Cart\SetBillingAddressOnCart #468

Manual testing scenarios (*)

1. Go to /dev/tests/static/ (CLI cd /dev/tests/static/ from project root folder)
2. Prepare your phpunit.xml from phpunit.xml.dist
3. run ../../../vendor/bin/phpunit
4. Tests results should be green

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[TomashKhamlai]

Usually @throws annotation tags are added only when exception is thrown explicitly in the function. Any other exceptions from parent methods are implicit and not annotated. "Missing @throws tag(s)" can be turned off in PHPStorm Inspections->PHP->PHPDoc

[vasilii-b]

Thanks for mentioning, @TomashKhamlai. I've added requested changes. Thank you!

[naydav]

Usually @throws annotation tags are added only when exception is thrown explicitly in the function

I little disagree with this statement. If I work with some API I will prefer to know which of exception could be thrown without submerging in implementation (does not matter will be thrown in current method or in some child classes)

Generally, it's about readability.

[TomashKhamlai]

@naydav. Checked. Works as expected

[ghost]

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.