-
Notifications
You must be signed in to change notification settings - Fork 154
GraphQl-535: provided catalog configs #650
GraphQl-535: provided catalog configs #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right that we don't need flat_catalog_category
. Let me list what I can see now will be useful to the PWA frontend in the future. Anything I don't list here can be removed from this PR if you need to.
SEO
product_url_suffix
: PWA definitely needs this to do accurate SEO routing; these configurations tell our router how to derive the URL key from the URL pathname.category_url_suffix
: PWA definitely needs this, see aboveproduct_use_categories
: PWA definitely needs this, see abovetitle_separator
: PWA can use this to render dynamic page titles.
Display
list_mode
: PWA can use this to control category/search rendering and pagination.grid_per_page_values
: See abovelist_per_page_values
: See abovegrid_per_page
: See abovelist_per_page
: See abovecatalog_default_sort_by
: See above
Nothing else from the Catalog config section is obviously useful to us (yet). @jimbo and @soumya-ashok and @tjwiebell and @supernova-at might have a different opinion based on UX best practice or known UI gaps, but I think this is plenty.
Thanks again!
@VitaliyBoyko, please, update PR according to last comment |
Hi @VitaliyBoyko, thank you for your contribution! |
These elements were added in magento/graphql-ce#650 Fixes magento/graphql-ce#768
* Document catalog configuration added to storeConfig query These elements were added in magento/graphql-ce#650 Fixes magento/graphql-ce#768 * Requested revisions
Description (*)
Provided catalog configs for PWA in scope of StoreConfig type.
Fixed Issues (if relevant)