Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

GraphQl-535: provided catalog configs #650

Merged

Conversation

VitaliyBoyko
Copy link
Contributor

@VitaliyBoyko VitaliyBoyko commented May 1, 2019

Description (*)

Provided catalog configs for PWA in scope of StoreConfig type.

{
  storeConfig{
    product_url_suffix,
    category_url_suffix,
    title_separator,
    list_mode,
    grid_per_page_values,
    list_per_page_values,
    grid_per_page,
    list_per_page,
    catalog_default_sort_by
  }
}

image

Fixed Issues (if relevant)

  1. Expose catalog configuration data as a new info query type. #535: Expose catalog configuration data as a new info query type.

@naydav naydav changed the title graphQl-535: provided catalog configs GraphQl-535: provided catalog configs May 2, 2019
Copy link

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right that we don't need flat_catalog_category. Let me list what I can see now will be useful to the PWA frontend in the future. Anything I don't list here can be removed from this PR if you need to.

SEO

  • product_url_suffix: PWA definitely needs this to do accurate SEO routing; these configurations tell our router how to derive the URL key from the URL pathname.
  • category_url_suffix: PWA definitely needs this, see above
  • product_use_categories: PWA definitely needs this, see above
  • title_separator: PWA can use this to render dynamic page titles.

Display

  • list_mode: PWA can use this to control category/search rendering and pagination.
  • grid_per_page_values: See above
  • list_per_page_values: See above
  • grid_per_page: See above
  • list_per_page: See above
  • catalog_default_sort_by: See above

Nothing else from the Catalog config section is obviously useful to us (yet). @jimbo and @soumya-ashok and @tjwiebell and @supernova-at might have a different opinion based on UX best practice or known UI gaps, but I think this is plenty.

Thanks again!

@naydav
Copy link
Contributor

naydav commented May 7, 2019

@VitaliyBoyko, please, update PR according to last comment
Thanks

@ghost
Copy link

ghost commented May 10, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 9f2f5b6 into 2.3-develop May 10, 2019
pmclain added a commit to pmclain/devdocs that referenced this pull request Jul 10, 2019
keharper pushed a commit to magento/devdocs that referenced this pull request Jul 25, 2019
* Document catalog configuration added to storeConfig query

These elements were added in magento/graphql-ce#650

Fixes magento/graphql-ce#768

* Requested revisions
@lenaorobei lenaorobei deleted the graphQL-535-provide-catalog-cofigs-for-pwa branch September 10, 2019 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants