Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Return error when invalid currentPage is provided #731

Merged
merged 4 commits into from
Jun 12, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Jun 4, 2019

Description (*)

Adds input validation for the minimum currentPage value

Fixed Issues (if relevant)

  1. currentPage: 0, currentPage: 1 and currentPage: -1 produces the same output for products query when filtering is used #727

Manual testing scenarios (*)

{
  products (
    filter: {
      sku: {
        like:"simple%"
      }
    }
    pageSize: 4
    currentPage: 0
  ) {
    items {
      sku
    }
  }
}

Queries with a current page value < 1 should return error:
currentPage value must be greater than 0.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Adds missing validation for the minimum page value

Fixes magento#727
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5218 has been created to process this Pull Request

naydav and others added 3 commits June 7, 2019 15:27
…ces the same output for products query when filtering is used

- added pageSize validation;
- fixed code style issues.
…ces the same output for products query when filtering is used

- removed redundant SuppressWarnings
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5218 has been created to process this Pull Request

@naydav naydav merged commit 5d4520b into magento:2.3-develop Jun 12, 2019
@ghost
Copy link

ghost commented Jun 12, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants