Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

graphQl-784: added validation for the lowercase country id in the quote address #790

Merged
merged 6 commits into from
Jul 30, 2019
Merged

graphQl-784: added validation for the lowercase country id in the quote address #790

merged 6 commits into from
Jul 30, 2019

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

Added validation with the message "Country Code cannot contain lowercase characters."

Fixed Issues (if relevant)

  1. Cover lowercase countryId in the shipping/billing address if provided by variables #784: Cover lowercase countryId in the shipping/billing address if provided by variables

@lenaorobei
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5494 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team merged commit dd0e02b into 2.3-develop Jul 30, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 30, 2019
@naydav
ENGCOM-5494: graphQl-784: added validation for the lowercase country …
968737f 
…id in the quote address #790
@naydav naydav mentioned this pull request Jul 30, 2019
Closed
@lenaorobei lenaorobei deleted the GraphQL-784-validate-lowercase-countryId branch September 10, 2019 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@naydav naydav

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Component: QuoteGraphQl Imported Partner: Atwix partners-contribution Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitaliyBoyko @lenaorobei @magento-engcom-team @naydav