This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
add Magento_QuoteGraphQl dependency to Magento_ConfigurableProductGra… #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The
Magento_ConfigurableProductGraphQl
module has a reference toCartItemInput
. This type is defined inMagento_QuoteGraphQl
.Manual testing scenarios (*)
replace: "*"
incomposer.json
.setup:upgrade
, modules will reorder inapp/etc/config.php
in such a way thatMagento_ConfigurableProductGraphQl
is loaded beforeMagento_QuoteGraphQl
.Questions or comments
This case is already covered by integration test
Magento\GraphQl\Controller\GraphQlControllerTest
, but it didn't catch because this test is run with all modules enabled, this wasn't the case for our project.Contribution checklist (*)