Added validation for store id in CMS Block

[Rus0]

Description (*)

Adding a filter for store id in the blocks, using the store send in the headers

Fixed Issues (if relevant)

1. magento/graphql-ce#691: cmsBlocks that has scope limited to specific Store View can be seen on other Store Views in case there are Blocks with identical identifiers on both Store Views

Manual testing scenarios (*)

1. All the steps in the ticket #691

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[lenaorobei]

Please see my comments.

[lenaorobei]

Suggested change

	"magento/module-store": "*",
	"magento/module-store": "*",

[Rus0]

??? I don't see any changes or comment @lenaorobei

[lenaorobei]

magento/module-store is redundant dependency

[Rus0]

If I don't set it, I get the error: Module Magento\CmsGraphQl has undeclared dependencies: hard [Magento\Store]

[lenaorobei]

Please see address comments.

[lenaorobei]

@magento run Functional Tests build

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5826 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5826 has been created to process this Pull Request

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5826 has been created to process this Pull Request

[TomashKhamlai]

Could you please merge the latest mainline to this PR?

In production mode, I am getting this error on schema loading

"debugMessage":"User Deprecated Functionality: GraphQL\\Type\\Definition\\Type::getInternalTypes is deprecated. Use Type::getStandardTypes()

I have seen this error several times on branches that are oudated.

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Rus0
✅ lenaorobei
❌ devilbox

---

devilbox seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[TomashKhamlai]

Well done! 👍

Checked. Works as expected

✔️ The title is according to Store headers
✔️ The content is according to Store headers
✔️ Variables which got values in the Store View scope are displayed as expected
✔️ Variables which were set in the global scope are displayed as expected

The problem

❌ If the block has the scope All store views it is not found.

Details of the problem

Request 1

query showCmsBlock(
  $identifiers: [String]
) {
  storeConfig {
    code
  }
  cmsBlocks(
    identifiers: $identifiers
  ) {
    items {
      content
      title
      identifier
    }
  }
}

Headers 1

No headers

Variables 1

{
  "identifiers": ["test-block-2"]
}

Response 1

{
  "errors": [
    {
      "message": "The CMS block with the \"test-block-2\" ID doesn't exist.",
      "extensions": {
        "category": "graphql-no-such-entity"
      },
      "locations": [
        {
          "line": 6,
          "column": 5
        }
      ],
      "path": [
        "cmsBlocks",
        "items",
        0
      ]
    }
  ],
  "data": {
    "storeConfig": {
      "code": "default"
    },
    "cmsBlocks": {
      "items": [
        null
      ]
    }
  }
}

Request 2

query showCmsBlock(
  $identifiers: [String]
) {
  storeConfig {
    code
  }
  cmsBlocks(
    identifiers: $identifiers
  ) {
    items {
      content
      title
      identifier
    }
  }
}

Headers 2

{
  "Store": "germstv"
}

Variables 2

{
  "identifiers": ["test-block-2"]
}

Response 2

{
  "errors": [
    {
      "message": "The CMS block with the \"test-block-2\" ID doesn't exist.",
      "extensions": {
        "category": "graphql-no-such-entity"
      },
      "locations": [
        {
          "line": 6,
          "column": 5
        }
      ],
      "path": [
        "cmsBlocks",
        "items",
        0
      ]
    }
  ],
  "data": {
    "storeConfig": {
      "code": "germstv"
    },
    "cmsBlocks": {
      "items": [
        null
      ]
    }
  }
}

Blocks enabled

Block that was requested

[lenaorobei]

@Rus0, could you please address found issues?

[Rus0]

Sure, I will later this week

…

On Tue, Oct 1, 2019 at 5:47 AM Lena Orobei ***@***.***> wrote: ***@***.**** requested changes on this pull request. @Rus0 <https://github.com/Rus0>, could you please address found issues? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#870?email_source=notifications&email_token=ABS3RGBXOUVMD7NOAA72QFTQMMTF3A5CNFSM4IRV26P2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGOTFVQ#pullrequestreview-295514838>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABS3RGHOT4VC3AB2TDPHBFLQMMTF3ANCNFSM4IRV26PQ> .

[lenaorobei]

@Rus0 unfortunately, I need to close this PR since there is no activity. Please feel free to reopen if you want to continue working on it. Thank you.