Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

graphQl-903: deprecated use_for_shipping in billing address schema #943

Merged

Conversation

VitaliyBoyko
Copy link
Contributor

Fixed Issues (if relevant)

  1. [Checkout] Replace use_for_shipping with same_as_shipping #903: [Checkout] Replace use_for_shipping with same_as_shipping

@VitaliyBoyko VitaliyBoyko added Contribution Day Tickets is good for start on Contribution Day Event: mageconf19 MageConf 2019 Contribution Day labels Sep 27, 2019
Co-Authored-By: Lena Orobei <oorobei@magento.com>
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5963 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the fact that use_for_shipping is deprecated we need to preserve its behaviour. It should be the same as same_as_shipping.

@ghost
Copy link

ghost commented Oct 2, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VitaliyBoyko VitaliyBoyko reopened this Oct 2, 2019
@@ -142,7 +142,7 @@ public function testSetNewBillingAddressWithUseForShippingParameter()
telephone: "88776655"
save_in_address_book: false
}
use_for_shipping: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep tests for both fields for now.

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about BC.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5963 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Oct 31, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants