-
Notifications
You must be signed in to change notification settings - Fork 154
graphQl-903: deprecated use_for_shipping in billing address schema #943
graphQl-903: deprecated use_for_shipping in billing address schema #943
Conversation
Co-Authored-By: Lena Orobei <oorobei@magento.com>
Hi @lenaorobei, thank you for the review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the fact that use_for_shipping
is deprecated we need to preserve its behaviour. It should be the same as same_as_shipping
.
…ipping' into GraphQl-903-deprecate-use-for-shipping
Hi @VitaliyBoyko, thank you for your contribution! |
@@ -142,7 +142,7 @@ public function testSetNewBillingAddressWithUseForShippingParameter() | |||
telephone: "88776655" | |||
save_in_address_book: false | |||
} | |||
use_for_shipping: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep tests for both fields for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment about BC.
…ing' of github.com:magento/graphql-ce into GraphQl-903-deprecate-use-for-shipping
Hi @lenaorobei, thank you for the review.
|
Hi @VitaliyBoyko, thank you for your contribution! |
Fixed Issues (if relevant)