Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Magento 2.3.2 - PWA - graphQl fetching Issue for phtml file called in static block #960 #971

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Magento 2.3.2 - PWA - graphQl fetching Issue for phtml file called in static block #960 #971

merged 5 commits into from
Oct 31, 2019

Conversation

XxXgeoXxX
Copy link
Member

Description (*)

original issue: #960

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@XxXgeoXxX XxXgeoXxX added Event: mageconf19 MageConf 2019 Contribution Day Progress: dev in progress labels Sep 27, 2019
@TomashKhamlai TomashKhamlai added Progress: ready for qa Add this in any case when you need some feedback, even if automated tests are failing QA passed and removed Progress: ready for qa Add this in any case when you need some feedback, even if automated tests are failing labels Sep 27, 2019
lenaorobei
lenaorobei suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magento\Widget\Model\Template\FilterEmulate does not have filter method. It is called from parent class.

Please move the emulation logic to the FilterEmulate class, create the same method like for widget with area emulation.

@XxXgeoXxX XxXgeoXxX requested a review from melnikovi as a code owner October 18, 2019 05:27
@XxXgeoXxX XxXgeoXxX requested a review from lenaorobei October 18, 2019 05:37
@XxXgeoXxX
Copy link
Member Author

Magento\Widget\Model\Template\FilterEmulate does not have filter method. It is called from parent class.

Please move the emulation logic to the FilterEmulate class, create the same method like for widget with area emulation.

Done

@lenaorobei
Copy link
Contributor

Please address failed builds.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6164 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@TomashKhamlai TomashKhamlai added QA in progress We are checking QA passed and removed QA in progress We are checking labels Oct 24, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2019
@lenaorobei
ENGCOM-6164: Magento 2.3.2 - PWA - graphQl fetching Issue for phtml f…
5c8ed12 
…ile called in static block #960 #971
@magento-engcom-team magento-engcom-team merged commit 106f398 into magento:2.3-develop Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@melnikovi melnikovi Awaiting requested review from melnikovi

Assignees

@lenaorobei lenaorobei

Labels
approved Award: bug fix Component: CmsGraphQl Component: Widget Event: mageconf19 MageConf 2019 Contribution Day Partner: ISM eCompany partners-contribution QA passed Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XxXgeoXxX @lenaorobei @magento-engcom-team @TomashKhamlai