This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Test coverage for exceptions in \Magento\CustomerGraphQl\Model\Customer\GetCustomer #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erify and try again." Ignore coverage for functionality that is related to the DB constraint violations. Reformat lines for LiveCodeTest Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
TomashKhamlai
commented
Oct 9, 2019
lenaorobei
reviewed
Oct 10, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/GetCustomerTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
reviewed
Oct 10, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/GetCustomerTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
reviewed
Oct 10, 2019
| /** | ||
| * @var AccountManagementInterface | ||
| */ | ||
| private $accountManagement; |
lenaorobei
reviewed
Oct 10, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/GetCustomerTest.php
Outdated
Show resolved
Hide resolved
lenaorobei
suggested changes
Oct 10, 2019
Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
lenaorobei
approved these changes
Oct 11, 2019
|
Hi @lenaorobei, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 22, 2019
…\Model\Customer\GetCustomer #994
|
Hi @TomashKhamlai, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Cover GraphQlAuthenticationException "This account isn't confirmed. Verify and try again."
Ignore coverage for functionality that is related to the DB constraint violations.
Reformat lines for LiveCodeTest
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)