Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Entity expansion with Pickup Location attributes #2182

Closed
swnsma opened this issue Apr 16, 2019 · 2 comments
Closed

Source Entity expansion with Pickup Location attributes #2182

swnsma opened this issue Apr 16, 2019 · 2 comments
Labels
Award: advanced Store Pickup
Milestone
Store Pickup Support

Comments

@swnsma
Copy link
Contributor

swnsma commented Apr 16, 2019

Description

Source entity need to be expanded with additional attributes for Pickup Location.
At least next attributes need to be added:

  • Front Name - which will be used for name of Pickup Location on Magneto Frontend.
  • Open Hours - attribute which will be used to show open hours of Pickup Location.

Please foresee next cases:

  • if source is not Pickup Location - attributes should hided or should not be required.
  • if source is Pickup Location - these attributes should become required.
@swnsma swnsma self-assigned this Apr 16, 2019
@novikor novikor assigned novikor and unassigned swnsma May 13, 2019
@novikor
Copy link
Contributor

novikor commented May 13, 2019

PR is expected this week.

novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
6a0b85f 
open_hours -> frontend_description
novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
f6d9bb5 
open_hours -> frontend_description
novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
2314c9f 
Frontend name and frontend description admin UI.
Some refactoring.
novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
748fd78 
Improved tests coverage
novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
0c974ba 
Show/Hide the pickup location fieldset depending from `is_pickup_location_active` value
novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
7426756 
Show/Hide the pickup location fieldset depending from `is_pickup_location_active` value
novikor added a commit that referenced this issue May 18, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
7559630 
Adjusted Pickup Location entity
@novikor novikor mentioned this issue May 18, 2019
Merged
4 tasks
@ishakhsuvarov ishakhsuvarov added this to the MSI Part III milestone May 29, 2019
@okorshenko okorshenko removed this from the MSI Part III milestone May 30, 2019
@ishakhsuvarov ishakhsuvarov added this to the Store Pickup Support milestone May 30, 2019
@swnsma
Copy link
Contributor Author

swnsma commented Jun 8, 2019

Merged #2182.

@swnsma swnsma closed this as completed Jun 8, 2019
ishakhsuvarov pushed a commit that referenced this issue Nov 22, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
4995e4c 
open_hours -> frontend_description
ishakhsuvarov pushed a commit that referenced this issue Nov 22, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
c537d6a 
Frontend name and frontend description admin UI.
Some refactoring.
ishakhsuvarov pushed a commit that referenced this issue Nov 22, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
d619398 
Improved tests coverage
ishakhsuvarov pushed a commit that referenced this issue Nov 22, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
290757e 
Show/Hide the pickup location fieldset depending from `is_pickup_location_active` value
ishakhsuvarov pushed a commit that referenced this issue Nov 22, 2019
@novikor
Source Entity expansion with Pickup Location attributes #2182.
789672d 
Adjusted Pickup Location entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Award: advanced Store Pickup
Projects
None yet
Milestone
Store Pickup Support
Development

No branches or pull requests
4 participants
@ishakhsuvarov @okorshenko @swnsma @novikor