Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Magento\InventoryCatalog\Plugin\InventoryApi\ApplyDataToLegacyCatalogInventoryAtReservationPlacingPlugin #368

Closed
naydav opened this issue Jan 3, 2018 · 3 comments
Closed

Fix Magento\InventoryCatalog\Plugin\InventoryApi\ApplyDataToLegacyCatalogInventoryAtReservationPlacingPlugin #368

naydav opened this issue Jan 3, 2018 · 3 comments
Assignees
@bartekszymanski

Comments

@naydav
Copy link

naydav commented Jan 3, 2018 •
edited by vrann
Loading

Need to uncomment and fix problem in
\Magento\InventoryCatalog\Plugin\InventoryApi\ApplyDataToLegacyCatalogInventoryAtReservationPlacingPlugin::afterExecute

  • unskip skipped tests (green now but should fail)

Functionality initially created in #269
@naydav naydav closed this as completed Jan 10, 2018
@naydav naydav reopened this Jan 11, 2018
@naydav naydav changed the title Need to adapt \Magento\Catalog\Model\Product::isSalable to MSI API Fix Magento\InventoryCatalog\Plugin\InventoryApi\ApplyDataToLegacyCatalogInventoryAtReservationPlacingPlugin Jan 11, 2018
@VitaliyBoyko VitaliyBoyko self-assigned this Jan 11, 2018
@VitaliyBoyko VitaliyBoyko mentioned this issue Jan 11, 2018
Closed
@bartekszymanski bartekszymanski mentioned this issue Mar 6, 2018
Merged
@maghamed
Copy link
Contributor

maghamed commented Mar 7, 2018

@bartekszymanski
looks like test for CreditMemo is still broken

1) Magento\Sales\Controller\Adminhtml\Order\CreditmemoTest::testAddCommentAction
Failed asserting that 93.0 matches expected 95.

@naydav
Copy link
Author

naydav commented Mar 9, 2018

#646

@naydav naydav closed this as completed Mar 9, 2018
@naydav
Copy link
Author

naydav commented Mar 9, 2018

CreditMemo will be fixed after finishing
#393

magento-devops-reposync-svc pushed a commit that referenced this issue Jul 17, 2023
@okolesnyk
Merge pull request #368 from magento-commerce/develop
e9d7e80 
update branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekszymanski bartekszymanski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@naydav @maghamed @vrann @VitaliyBoyko @bartekszymanski