Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust StockItem aggregation functionality to support OutOfStock SourceItem during the calculation #65

Closed
maghamed opened this issue Sep 1, 2017 · 2 comments
Closed

Adjust StockItem aggregation functionality to support OutOfStock SourceItem during the calculation #65

maghamed opened this issue Sep 1, 2017 · 2 comments
Assignees
@naydav @larsroettig
Labels
StockItem Indexer

Comments

@maghamed
Copy link
Contributor

maghamed commented Sep 1, 2017 •
edited by naydav
Loading

Adjust StockItem aggregation functionality to support OutOfStock SourceItem during the calculation.

Currently, indexation mechanism does not take into account that some of the source items could be out of Stock and just sum up all the quantities together.

We need to fix that logic.

So, if there are 3 Sources assigned to the single Stock.
Source A: Qty - 10 Status: In Stock
Source B: Qty - 20 Status: Out Stock
Source C: Qty - 30 Status: In Stock

Current Indexation result is: 10 + 20 + 30 = 60

Expected Behaviour: 10 + 30 = 40

Changes should be covered with Unit Tests and MUST be covered by integration tests (because we can not check full re-indexation work via api-functional tests)
@larsroettig larsroettig self-assigned this Sep 1, 2017
@larsroettig
Copy link
Member

https://github.com/magento-engcom/magento2/pull/76

@naydav
Copy link

naydav commented Sep 15, 2017

Merged in #76

@naydav naydav closed this as completed Sep 15, 2017
@smoskaluk smoskaluk mentioned this issue Mar 23, 2018
Closed
mmansoor-magento pushed a commit that referenced this issue Feb 16, 2021
@zakdma
Merge pull request #65 from magento-tsg-csl3/MC-40718
3d88644 
MC-40718: [Cloud]The swatches are not strike-through when the invento…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naydav naydav

@larsroettig larsroettig

Labels
StockItem Indexer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naydav @maghamed @larsroettig