Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new module InventoryCatalog #102

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Conversation

bartekszymanski
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Copy link
Contributor

@maghamed maghamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more descriptive Readme for newly introduced module

@@ -0,0 +1,5 @@
# InventoryCatalog

**InventoryCatalog** provides implementation for bridge between **Inventory** and **Catalog**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to describe in more details what does "bridge" means in current context.

Because we introducing this module for better modularity and separation of concerns

@naydav naydav merged commit df17aec into develop Sep 22, 2017
@maghamed maghamed deleted the inventory-catalog-model branch December 11, 2018 18:13
sidolov pushed a commit that referenced this pull request Oct 18, 2019
Merging MC-20181 changes to MC-20644 branch
sidolov added a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants