Introduce new module InventoryCatalog #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maghamed
suggested changes
Sep 19, 2017
Contributor
maghamed
left a comment
maghamed
left a comment
There was a problem hiding this comment.
Please provide more descriptive Readme for newly introduced module
| @@ -0,0 +1,5 @@ | |||
| # InventoryCatalog | |||
|
|
|||
| **InventoryCatalog** provides implementation for bridge between **Inventory** and **Catalog**. | |||
Contributor
There was a problem hiding this comment.
We need to describe in more details what does "bridge" means in current context.
Because we introducing this module for better modularity and separation of concerns
sidolov
pushed a commit
that referenced
this pull request
Oct 18, 2019
Merging MC-20181 changes to MC-20644 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist