Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Stock in Data Install #113

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Conversation

bartekszymanski
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. Add default Stock in Data Install #95: Add default Stock in Data Install

Manual testing scenarios

  1. Remove data version from table "setup_module", Magento_InventoryCatalog module
  2. Run bin/magento setup:upgrade
  3. Default stock should be visible in table "inventory_stock" with id: 1

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@larsroettig larsroettig self-requested a review September 29, 2017 06:54
@larsroettig
Copy link
Member

+1 Approved

/**
* Class GetDefaultStock
*/
class GetDefaultStock extends WebapiAbstract
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls, add Test suffix to file
And change dockblock like 'Test that default Stock is present after installation'

@maghamed maghamed merged commit 48bd40b into develop Oct 4, 2017
@maghamed maghamed deleted the default-stock-install-data branch December 11, 2018 18:15
magento-cicd2 pushed a commit that referenced this pull request Apr 27, 2021
MC-41067: Sources pagination does not work in Admin during shipping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants